Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve behavior of testsuite on Windows octave #603

Merged
merged 1 commit into from Apr 8, 2015
Merged

improve behavior of testsuite on Windows octave #603

merged 1 commit into from Apr 8, 2015

Conversation

PeterPablo
Copy link
Member

See #602 for discussion.

@PeterPablo PeterPablo added this to the Fix ACID Test milestone Apr 8, 2015
@PeterPablo PeterPablo mentioned this pull request Apr 8, 2015
Merged
@PeterPablo
Copy link
Member Author

@okomarov, could you please test this? If you agree, please go forward and merge. This change does not influence Travis, as it only matches Windows+Octave.

@okomarov
Copy link
Member

okomarov commented Apr 8, 2015

It improves things quite a bit! From 13 unmatching to 7. No effect on the 27 unreliable ones.

okomarov pushed a commit that referenced this pull request Apr 8, 2015
Merge pull request #603 from PeterPablo/improve_ACID_win_octave
3330e4f 
improve behavior of testsuite on Windows octave
@okomarov okomarov merged commit 3330e4f into matlab2tikz:develop Apr 8, 2015
@PeterPablo
Copy link
Member Author

The other six match now? That is nice, considering this is such a minor change -- thanks to your investigation and DIFFing.

@PeterPablo PeterPablo deleted the improve_ACID_win_octave branch April 8, 2015 14:47
@okomarov
Copy link
Member

okomarov commented Apr 8, 2015

Yes, 6 hashes match now. I reckon the remaining 7 do not match due to numerical differences.

@okomarov okomarov added the +0.0.1 label Apr 8, 2015
@PeterPablo
Copy link
Member Author

Please go ahead and upload your output for one of the failing ones in the discussion of PR #604. Please choose a testcase with comparatively small output and once with the PR applied and once without.
PR #604 should solve numerical differences for numbers close to eps, though does NOT solve problems related to different figure dimensions (we need a separate solution).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
+0.0.1
Projects
None yet
Milestone
Fix ACID Test
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@PeterPablo @okomarov