2to3 #14
Merged
2to3 #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 25, 2019 19:43
Ran the 2to3 utility to perform syntatic transformation of Python 2 to Python 3. The code does not work at this stage, but I wanted to separate out each step.
This part deals with the difference in sockets between Python 2 and 3. In python 2, it is perfectly fine to send a string via a socket like so. However, sockets in Python 3 can only send byte strings. To handle this, the only change I made was to encode a string before it was sent, and decode the string just after it is received.
Instead of using the script command to record output from the server, everything that is displayed to the screen is also sent to the logfile.
|
@matloff You can either merge this PR in or manually merge with https://github.com/MKDonnelly/omsi/tree/2to3 to pull in the Python 3 changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This set of commits covers the following: