Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SWAT] Transform rightButton into a rightView #4

Merged
merged 3 commits into from
Jan 12, 2022
Merged

[SWAT] Transform rightButton into a rightView #4

merged 3 commits into from
Jan 12, 2022

Conversation

jpedrosg
Copy link
Contributor

What does this PR do?

  • Transform the UIButton rightButton into a UIView rightView. Now we can have multiple right buttons by sending a stackView to it.

Why?

  • Now Multiple Images feature require a second button on ProductDetail page, in order to do that the MMSplitViewController component needed an update.

Screenshots/Recordings (if appropriate)
IMG_7014 IMG_7013

@jpedrosg
Transform rightButton into a rightView
c9169a8 
- Now we can have multiple right buttons by sending a stackView to it
dtorres
dtorres approved these changes Jan 12, 2022
View reviewed changes
Copy link
Contributor

@dtorres dtorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MMSplitViewController.xcodeproj/project.pbxproj Outdated Show resolved Hide resolved
izhuster
izhuster approved these changes Jan 12, 2022
View reviewed changes
Copy link

@izhuster izhuster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@sgarciaanato sgarciaanato merged commit 8c44f70 into matmartinez:main Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtorres dtorres dtorres approved these changes

@izhuster izhuster izhuster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jpedrosg @dtorres @izhuster @sgarciaanato