Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reviewed "Internationalization" guide #37

Merged
merged 1 commit into from
Nov 26, 2014
Merged

Conversation

mnapoli
Copy link
Contributor

@mnapoli mnapoli commented Nov 23, 2014

Related to #22

I'm opening this as a PR because it depends on #34 to be merged (else code blocks will not work). Again, I've had to use fenced code blocks because syntax highlighting was behaving differently on every example.

@mattab
Copy link
Member

mattab commented Nov 25, 2014

maybe add a link in bottom of article to our blog post how to make plugin multilingual ?

feel free to merge

@mnapoli
Copy link
Contributor Author

mnapoli commented Nov 25, 2014

@mattab the guide should cover it already and the blog post will become outdated at some point. Adding blog posts as articles (i.e. in menus) is less a problem because it's very visible that we have to move the post into the developer documentation in the near future, but with a small link like that we will forget about it and it will only confuse users.

mnapoli added a commit that referenced this pull request Nov 26, 2014
Reviewed "Internationalization" guide
@mnapoli mnapoli merged commit a7e58c8 into master Nov 26, 2014
@mnapoli mnapoli deleted the internationalization branch November 26, 2014 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants