Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add section about type hinting API method parameters #684

Merged
merged 2 commits into from Dec 14, 2022
Merged

Add section about type hinting API method parameters #684

merged 2 commits into from Dec 14, 2022

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Dec 2, 2022

Description:

refs matomo-org/matomo#20016

Review

@sgiehl sgiehl added this to the Matomo 5 milestone Dec 2, 2022
@sgiehl sgiehl mentioned this pull request Dec 12, 2022
Merged
11 tasks
bx80
bx80 approved these changes Dec 13, 2022
View reviewed changes
Copy link
Contributor

@bx80 bx80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a well written explanation, easy to understand 👍

@sgiehl sgiehl merged commit 92227a1 into live Dec 14, 2022
@sgiehl sgiehl deleted the typehinting branch December 14, 2022 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bx80 bx80 bx80 approved these changes

Assignees
No one assigned
Labels
Needs Review
Projects
None yet
Milestone
Matomo 5
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sgiehl @bx80