Skip to content

Commit

Permalink
Bugfix/android streamy detection (#5533)
Browse files Browse the repository at this point in the history
* Fixes #1.
Implemented dbrowser and Streamy browsers detection.

* Fixed indents in Browser.php.

* Fixed dbrowser's default engine.

* Moved Streamy regex before Chrome one.
Fixes #7.
  • Loading branch information
wazelin authored and sgiehl committed Aug 25, 2016
1 parent feb8570 commit 913aaea
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 7 deletions.
8 changes: 8 additions & 0 deletions Tests/Parser/Client/fixtures/browser.yml
Original file line number Diff line number Diff line change
Expand Up @@ -1231,6 +1231,14 @@
short_name: ST
version: "1.1.11"
engine: WebKit
-
user_agent: Mozilla/5.0 (Linux; Android 6.0.1; SM-G920F Build/MMB29K) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/48.0.2564.116 Crosswalk/18.48.477.13 Mobile Safari/537.36 Streamy/1.1.193
client:
type: browser
name: Streamy
short_name: ST
version: "1.1.193"
engine: WebKit
-
user_agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-us) AppleWebKit/125.5.7 (KHTML, like Gecko) SunriseBrowser/0.833
client:
Expand Down
16 changes: 9 additions & 7 deletions regexes/client/browsers.yml
Original file line number Diff line number Diff line change
Expand Up @@ -433,6 +433,15 @@
name: 'Samsung Browser'
version: '$1'

#Streamy
#This browser is built on top of Chromium.
#It should be checked first.
- regex: 'Streamy(?:/(\d+[\.\d]+))?'
name: 'Streamy'
version: '$1'
engine:
default: 'WebKit'

#Chrome
- regex: 'CrMo(?:/(\d+[\.\d]+))?'
name: 'Chrome Mobile'
Expand Down Expand Up @@ -865,13 +874,6 @@
engine:
default: 'WebKit'

#Streamy
- regex: 'Streamy(?:/(\d+[\.\d]+))?'
name: 'Streamy'
version: '$1'
engine:
default: 'WebKit'

#Sunrise
- regex: 'Sunrise(?:Browser)?(?:/(\d+[\.\d]+))?'
name: 'Sunrise'
Expand Down

0 comments on commit 913aaea

Please sign in to comment.