Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phones on Cyanogen ROM #3

Closed
spyjo opened this issue Apr 29, 2014 · 1 comment
Closed

Phones on Cyanogen ROM #3

spyjo opened this issue Apr 29, 2014 · 1 comment

Comments

@spyjo
Copy link

spyjo commented Apr 29, 2014

Hello,

Can you please add the support of this User agent ?
Mozilla/5.0 (Linux; Android 4.4.2; One X Build/KVT49L) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/34.0.1847.114 Mobile Safari/537.36

This is a HTC One X on Cyanogen 11.

It seems the vendor string "HTC" is missing, may be it's also the case for other phones on Cyanogen, like these ones, the vendor "Samsung" is also missing:
http://www.webapps-online.com/online-tools/user-agent-strings/dv/plugin139699/cyanogen-mod

Thank you

@sgiehl
Copy link
Member

sgiehl commented Apr 29, 2014

You're right. For some custom roms the vendor part is missing.
I'll add a special detection for the HTC One series.

But the detection for the OS will stay Android 4.4. For now I don't want to start detecting special Custom Roms. Maybe we will add support for that later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants