We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
It seems like discardDetails option doesn't work as descibed here. It still performs walk through the array of bot regexes when set to true.
discardDetails
true
Shouldn't this part of \DeviceDetector\Parser\Bot::parse() method
\DeviceDetector\Parser\Bot::parse()
if ($this->preMatchOverall()) { foreach ($this->getRegexes() as $regex) { $matches = $this->matchUserAgent($regex['regex']); if ($matches) { if ($this->discardDetails) { $result = true; break; } unset($regex['regex']); $result = $regex; break; } } }
be something like this instead?
if ($this->preMatchOverall()) { if ($this->discardDetails) { $result = true; } else { foreach ($this->getRegexes() as $regex) { $matches = $this->matchUserAgent($regex['regex']); if ($matches) { unset($regex['regex']); $result = $regex; break; } } } }
The text was updated successfully, but these errors were encountered:
5f5a1f1
No branches or pull requests
It seems like
discardDetails
option doesn't work as descibed here.It still performs walk through the array of bot regexes when set to
true
.Shouldn't this part of
\DeviceDetector\Parser\Bot::parse()
methodbe something like this instead?
The text was updated successfully, but these errors were encountered: