Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds detection for Condor devices (www.condor.dz) #5677

Merged
merged 5 commits into from
Nov 8, 2017
Merged

Adds detection for Condor devices (www.condor.dz) #5677

merged 5 commits into from
Nov 8, 2017

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Nov 7, 2017

ping @Findus23

@coveralls
Copy link

coveralls commented Nov 7, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 97.949% when pulling 3b7a6e6 on improvements into a4333d4 on master.

Findus23 added a commit to matomo-org/matomo-icons that referenced this pull request Nov 8, 2017
@Findus23
add Condor (matomo-org/device-detector#5677)
8b61cb8
Findus23
Findus23 requested changes Nov 8, 2017
View reviewed changes
Copy link
Member

@Findus23 Findus23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a "M" got lost in user_agent: ozilla/5.0 [...]

Tests/fixtures/smartphone-1.yml Outdated
@@ -700,6 +700,26 @@
os_family: Android
browser_family: Android Browser
-
user_agent: ozilla/5.0 (Linux; Android 7.1.2; MZ-M6 Note Build/N2G47H) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/45.0.2454.94 Mobile Safari/537.36
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess a "M" got lost here.

@Findus23
Copy link
Member

Findus23 commented Nov 8, 2017

Add logo in matomo-org/matomo-icons@8b61cb8

@coveralls
Copy link

coveralls commented Nov 8, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 97.949% when pulling c2d6fc2 on improvements into a4333d4 on master.

@sgiehl sgiehl merged commit 2300227 into master Nov 8, 2017
@sgiehl sgiehl deleted the improvements branch November 8, 2017 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Findus23 Findus23 Findus23 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sgiehl @coveralls @Findus23