Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds detection for various Huawei and Samsung devices (part II) #5688

Merged
merged 1 commit into from
Nov 26, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
62 changes: 61 additions & 1 deletion Tests/fixtures/smartphone-5.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3985,7 +3985,7 @@
device:
type: smartphone
brand: HU
model: P8 Lite
model: P8 Lite (2015)
os_family: Android
browser_family: Chrome
-
Expand Down Expand Up @@ -4088,3 +4088,63 @@
model: GALAXY A3 (2017)
os_family: Android
browser_family: Chrome
-
user_agent: Mozilla/5.0 (Linux; Android 5.1.1; SM-J320FN Build/LMY47V) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.91 Mobile Safari/537.36
os:
name: Android
short_name: AND
version: 5.1.1
platform: ""
client:
type: browser
name: Chrome Mobile
short_name: CM
version: 55.0.2883.91
engine: Blink
engine_version: ""
device:
type: smartphone
brand: SA
model: GALAXY J3 (2016)
os_family: Android
browser_family: Chrome
-
user_agent: Mozilla/5.0 (Linux; Android 7.0; VTR-L09 Build/HUAWEIVTR-L09) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.116 Mobile Safari/537.36
os:
name: Android
short_name: AND
version: "7.0"
platform: ""
client:
type: browser
name: Chrome Mobile
short_name: CM
version: 60.0.3112.116
engine: Blink
engine_version: ""
device:
type: smartphone
brand: HU
model: P10
os_family: Android
browser_family: Chrome
-
user_agent: Mozilla/5.0 (Linux; Android 7.0; PRA-LX1 Build/HUAWEIPRA-LX1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3163.98 Mobile Safari/537.36
os:
name: Android
short_name: AND
version: "7.0"
platform: ""
client:
type: browser
name: Chrome Mobile
short_name: CM
version: 61.0.3163.98
engine: Blink
engine_version: ""
device:
type: smartphone
brand: HU
model: P8 Lite (2017)
os_family: Android
browser_family: Chrome
10 changes: 8 additions & 2 deletions regexes/device/mobiles.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2396,8 +2396,12 @@ Huawei:
model: 'Honor 5C Dual SIM'
- regex: '(?:Honor_|HW-)?NEM-L21[);/ ]'
model: 'Honor 7 Lite'
- regex: 'ALE-L21'
model: 'P8 Lite'
- regex: 'ALE-L(02|21|23)'
model: 'P8 Lite (2015)'
- regex: 'PRA-LX1'
model: 'P8 Lite (2017)'
- regex: 'VTR-L09'
model: 'P10'
- regex: 'CAM-L21'
model: 'Y6II'
- regex: 'T1-A21w'
Expand Down Expand Up @@ -4565,6 +4569,8 @@ Samsung:
model: 'GALAXY A5 (2017)'
- regex: '(?:SAMSUNG-)?GT-I9301I'
model: 'GALAXY S III Neo'
- regex: '(?:SAMSUNG-)?SM-J320FN'
model: 'GALAXY J3 (2016)'
- regex: '(?:SAMSUNG-)?SM-J500FN'
model: 'GALAXY J5'
- regex: '(?:SAMSUNG-)?SM-G850F'
Expand Down