Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detection of LG OLED models #5724

Merged
merged 4 commits into from Mar 23, 2018
Merged

Detection of LG OLED models #5724

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
75c5bc7
Detection of LG OLED models
JanMachEU Mar 22, 2018
020cb29
Improve regex
sgiehl Mar 23, 2018
7b6b966
Adds some tests
sgiehl Mar 23, 2018
e5090a5
fix regex
sgiehl Mar 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
40 changes: 40 additions & 0 deletions Tests/fixtures/tv.yml
View file
Open in desktop
Expand Up @@ -1055,6 +1055,46 @@
model: NetCast 4.0
os_family: GNU/Linux
browser_family: Safari
-
user_agent: Mozilla/5.0 (Web0S; Linux/SmartTV) AppleWebKit/537.36 (KHTML, like Gecko) QtWebEngine/5.2.1 Chrome/38.0.2125.122 Safari/537.36 HbbTV/1.2.1 (+DRM; LGE; OLED55B6J-Z; WEBOS3.0 04.30.65; W3_K2L;)
os:
name: webOS
short_name: WOS
version: ""
platform: ""
client:
type: browser
name: Chrome
short_name: CH
version: "38.0.2125.122"
engine: Blink
engine_version: ""
device:
type: tv
brand: LG
model: OLED55B6J
os_family: Other Mobile
browser_family: Chrome
-
user_agent: Mozilla/5.0 (Web0S; Linux/SmartTV) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/38.0.2125.122 Safari/537.36 HbbTV/1.2.1 (+DRM; LGE; OLED65C7V-Z; WEBOS3.5 04.70.30; W3_M16P;)
os:
name: webOS
short_name: WOS
version: ""
platform: ""
client:
type: browser
name: Chrome
short_name: CH
version: 38.0.2125.122
engine: Blink
engine_version: ""
device:
type: tv
brand: LG
model: OLED65C7V
os_family: Other Mobile
browser_family: Chrome
-
user_agent: Mozilla/5.0 (Web0S; Linux/SmartTV) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/38.0.2125.122 Safari/537.36 HbbTV/1.2.1 (+DRM; LGE; 49UH664V-ZC; WEBOS3.0 05.30.02; W3_M16;)
os:
Expand Down
2 changes: 2 additions & 0 deletions regexes/device/televisions.yml
View file
Open in desktop
Expand Up @@ -101,6 +101,8 @@ LG:
models:
- regex: '(NetCast [0-9]{1}.[0-9]{1}|GLOBAL_PLAT3)'
model: '$1'
- regex: '(OLED[0-9]{2}[A-Z][0-9][A-Z])'
model: '$1'
- regex: 'LGE;? ?([0-9]{2}[A-Z]{2}[0-9]{2,4}[A-Z]?)'
model: '$1'

Expand Down