Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds detection for GoMobile devices #5843

Merged
merged 1 commit into from Oct 17, 2018
Merged

Adds detection for GoMobile devices #5843

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions Parser/Device/DeviceParserAbstract.php
View file
Open in desktop
Expand Up @@ -178,6 +178,7 @@ abstract class DeviceParserAbstract extends ParserAbstract
'GC' => 'GOCLEVER',
'GL' => 'Goly',
'GO' => 'Google',
'G1' => 'GoMobile',
'GR' => 'Gradiente',
'GU' => 'Grundig',
'HA' => 'Haier',
Expand Down
60 changes: 60 additions & 0 deletions Tests/fixtures/smartphone-1.yml
View file
Open in desktop
Expand Up @@ -90,6 +90,66 @@
model: Alumini 2
os_family: Android
browser_family: Unknown
-
user_agent: Mozilla/5.0 (Linux; Android 7.0; GO Onyx Build/NRD90M) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3163.98 Mobile Safari/537.36
os:
name: Android
short_name: AND
version: "7.0"
platform: ""
client:
type: browser
name: Chrome Mobile
short_name: CM
version: 61.0.3163.98
engine: Blink
engine_version: ""
device:
type: smartphone
brand: G1
model: Go Onyx
os_family: Android
browser_family: Chrome
-
user_agent: Mozilla/5.0 (Linux; Android 6.0; GO503 Build/MRA58K) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/60.0.3112.116 Mobile Safari/537.36
os:
name: Android
short_name: AND
version: "6.0"
platform: ""
client:
type: browser
name: Chrome Mobile
short_name: CM
version: 60.0.3112.116
engine: Blink
engine_version: ""
device:
type: smartphone
brand: G1
model: Go503
os_family: Android
browser_family: Chrome
-
user_agent: Mozilla/5.0 (Linux; Android 5.1; GO1402 Build/LMY47D) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3112.107 Mobile Safari/537.36
os:
name: Android
short_name: AND
version: "5.1"
platform: ""
client:
type: browser
name: Chrome Mobile
short_name: CM
version: 60.0.3112.107
engine: Blink
engine_version: ""
device:
type: smartphone
brand: G1
model: Go1402
os_family: Android
browser_family: Chrome
-
user_agent: Mozilla/5.0 (Linux; Android 7.0; U PULSE Build/NRD90M; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/67.0.3396.87 Mobile Safari/537.36 Instagram 51.0.0.20.85 Android (24/7.0; 320dpi; 720x1184; WIKO; U PULSE; v3961; mt6735; fr_FR; 115211358)
os:
Expand Down
10 changes: 10 additions & 0 deletions regexes/device/mobiles.yml
View file
Open in desktop
Expand Up @@ -2576,6 +2576,7 @@ Gigaset:
model: '$1'
- regex: 'Gigaset ([^;/)]+)[);/ ]'
model: '$1'

# Gionee
Gionee:
regex: '(?:GIO-)?GIONEE[ _-]?[a-z0-9]+|(?:Dream_D1|V188S?|GN[0-9]{3,4}[a-z]?)[);/ ]|F103(?: Pro)? Build|P5 mini Build'
Expand Down Expand Up @@ -2653,6 +2654,15 @@ GOCLEVER:
model: 'Libra 97'
device: 'tablet'

# GoMobile
GoMobile:
regex: 'GO Onyx|GO[0-9]{3,4}'
device: 'smartphone'
models:
- regex: 'GO Onyx'
model: 'Go Onyx'
- regex: 'GO([0-9]{3,4})'
model: 'Go$1'

# Goly
Goly:
Expand Down