Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds detection for Servo browser engine #6093

Merged
merged 8 commits into from Nov 24, 2019
Merged

Adds detection for Servo browser engine #6093

merged 8 commits into from Nov 24, 2019

Conversation

liviuconcioiu
Copy link
Collaborator

No description provided.

mimmi20
mimmi20 suggested changes Nov 20, 2019
View reviewed changes
Copy link
Contributor

@mimmi20 mimmi20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a new rule for Firefox with Servo engine to make sure to not change the current detections.

regexes/client/browsers.yml Outdated Show resolved Hide resolved
Tests/fixtures/smartphone-3.yml Outdated Show resolved Hide resolved
Tests/fixtures/desktop.yml Outdated Show resolved Hide resolved
@liviuconcioiu
Revert "Fix"
bbf6687 
This reverts commit cb7f5ca.
@liviuconcioiu
Revert "Fix"
cf5ad98 
This reverts commit c59ddf9.
@liviuconcioiu
Revert "Fix"
9869de6 
This reverts commit 702ba4a.
@liviuconcioiu
Fix
a131f4f
@sgiehl sgiehl merged commit 04a2f11 into matomo-org:master Nov 24, 2019
@liviuconcioiu liviuconcioiu deleted the servoengine branch November 25, 2019 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimmi20 mimmi20 mimmi20 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@liviuconcioiu @mimmi20 @sgiehl