Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OnlineOrNot to bots.yml #7411

Merged
merged 4 commits into from May 26, 2023
Merged

Add OnlineOrNot to bots.yml #7411

merged 4 commits into from May 26, 2023

Conversation

rozenmd
Copy link
Contributor

@rozenmd rozenmd commented May 25, 2023 •
edited by sanchezzzhak

Description:

This PR adds OnlineOrNot to matomo's bot detection. The full user agent of the bot is OnlineOrNot.com_bot_1.0_(https://onlineornot.com).

Review

sanchezzzhak
sanchezzzhak requested changes May 25, 2023
View reviewed changes
Copy link
Collaborator

@sanchezzzhak sanchezzzhak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi, add test to Tests/fixtures/bots.yml file

@rozenmd
Copy link
Contributor Author

rozenmd commented May 25, 2023

Thanks @sanchezzzhak, added

@rozenmd rozenmd requested a review from sanchezzzhak May 25, 2023 20:31
@sanchezzzhak
Copy link
Collaborator

generate fixture test

cd fork project
php misc/test.php "OnlineOrNot.com_bot_1.0_(https://onlineornot.com)"

@sanchezzzhak sanchezzzhak merged commit cc4eb16 into matomo-org:master May 26, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanchezzzhak sanchezzzhak sanchezzzhak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rozenmd @sanchezzzhak