Regex syntax: escape literal \.

[katef]

Description:

Many regexps here accidentally have unescaped . (meaning to match any character), where they're intended to match a literal dot character. I've made a pass to add these escapes.

I have made no other changes in this PR, to keep the diff clear.

This probably doesn't make much difference for backtracing regex engines, but for DFA-based regexes it helps reduce combinatorial explosions in state machine size.

Review

• Functional review done
• Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
• Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
• Security review done
• Wording review done
• Code review done
• Tests were added if useful/possible
• Reviewed for breaking changes
• Developer changelog updated if needed
• Documentation added if needed
• Existing documentation updated if needed

[liviuconcioiu]

Hi @katef!

I've made some suggestions to your changes, because tests don't pass.

See https://github.com/matomo-org/device-detector/actions/runs/8266869828/job/22617112820?pr=7626