New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect new brand TriaPlay and Detect devices for exist brands #7642
Conversation
feat(device) detect brand Vivo: Y02t (V2252), Y100 (V2239), Y35m (V2230A) feat(device) detect brand T-Mobile: REVVL 6x 5G (TMRV065G), T Phone (2023) feat(device) detect brand Sigma: X-Treme PQ55 feat(device) detect brand Xiaomi: 14 Pro, 13 Lite feat(device) detect brand Casper: VIA M35 feat(device) detect brand Lenovo: Xiaoxin Pad Pro 12.7" (TB371FC)
feat(device) detect brand Samsung: Galaxy Tab S9+ 12.4" (SM-X810), Galaxy Tab S9 12.4" 5G (SM-X716B)
feat(device) detect brand ZTE: Blade V50 Vita feat(device) detect brand Sky: Elite B63 feat(device) detect brand Nokia: G42 5G feat(device) detect brand Motorola: ThinkPhone feat(device) detect brand Casper: VIA M30 Plus feat(device) detect brand Lenovo: Tab M9 (TB310FU) feat(device) detect brand Samsung: Galaxy A03s (SM-S135DL), Galaxy A33 5G (SM-A336BN), Galaxy Tab A9+ 11.0" 5G (SM-X216B)
engine_version: 119.0.6045.163 | ||
device: | ||
type: tv | ||
brand: TriaPlay |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was not able to find anything like TriaPlay
, but I found Tria
https://competition.adesignaward.com/gooddesign.php?ID=29015. On the other hand on https://docs.google.com/spreadsheets/d/1kdnHLt673EjoAJisOal2uIpcmVS2Defbgk1ntWRLY3E/edit#gid=1566561225 I did find TriaPlayBox
, and searching for TriaPlayBox
from TriaPlay
, but I fail to find any evidence of this being a real device, besides https://www.osta.ee/android-go3-triaplaybox-178910683.html which shows seemingly a different device. Are we sure this device is real?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://storage.googleapis.com/play_public/supported_devices.html
https://staticweb.tvbanywhere.com/certified-android-TV-list.pdf
https://support.fubo.tv/hc/en-us/articles/115002183228-What-devices-can-I-watch-Fubo-on
https://developers.google.com/zero-touch/resources/manufacturer-names
Manufacture | TV Provider |
---|---|
Skyworth | GO3 |
Geniatech | TriaPlay |
I trust the certified list more
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should not the brand be Geniatech
then, and TriaPlay
- model?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already have other brands like this. Orange
, Vodafone
, Turkcell
, Verizon
, TCL A2 (TracFone A507DL)
for example. It's better to stick with Google Play naming where possible.
@sanchezzzhak probably is best to add a comment to the regex for future detections, so we know is a Geniatech
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Simbiat not always, since major players can produce products for a specific brand or trade market
(not every brand has its own capabilities to create a full-fledged production)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My problem is more with the fact, that I can't find any evidence of a device or brand existing. Orange, Vodafone and other ISPs - they have websites. TriaPlay seems to be mentioned only in such lists, as mentioned above.
No description provided.