use tags for docker #264
Closed
use tags for docker #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J0WI
reviewed
Nov 26, 2022
Co-authored-by: J0WI <J0WI@users.noreply.github.com>
J0WI
reviewed
Nov 28, 2022
| @@ -26,7 +26,7 @@ | |||
| You can run the Matomo container and service like so: | |||
|
|
|||
| ```bash | |||
| docker run -d --link some-mysql:db matomo | |||
| docker run -d --link some-mysql:db matomo:4-apache | |||
There was a problem hiding this comment.
Suggested change
| docker run -d --link some-mysql:db matomo:4-apache | |
| docker run -d --link some-mysql:db matomo |
There was a problem hiding this comment.
The goal of this PR is to restrict the tag to major releases of Matomo and its services. This change would contradict this goal.
There was a problem hiding this comment.
These are just examples. IMHO users should pin tags individually if they need to.
| @@ -13,7 +13,7 @@ services: | |||
| - ./db.env | |||
|
|
|||
| app: | |||
| image: matomo | |||
| image: matomo:4-apache | |||
There was a problem hiding this comment.
Suggested change
| image: matomo:4-apache | |
| image: matomo |
| @@ -13,7 +13,7 @@ services: | |||
| - ./db.env | |||
|
|
|||
| app: | |||
| image: matomo:fpm-alpine | |||
| image: matomo:4-fpm-alpine | |||
There was a problem hiding this comment.
Suggested change
| image: matomo:4-fpm-alpine | |
| image: matomo:fpm-alpine |
| @@ -36,7 +36,7 @@ This assumes you've already launched a suitable MySQL or MariaDB database contai | |||
| Use a Docker volume to keep persistent data: | |||
|
|
|||
| ```console | |||
| docker run -d -p 8080:80 --link some-mysql:db -v matomo:/var/www/html matomo | |||
| docker run -d -p 8080:80 --link some-mysql:db -v matomo:/var/www/html matomo:4-apache | |||
There was a problem hiding this comment.
Suggested change
| docker run -d -p 8080:80 --link some-mysql:db -v matomo:/var/www/html matomo:4-apache | |
| docker run -d -p 8080:80 --link some-mysql:db -v matomo:/var/www/html matomo |
J0WI
added a commit
to J0WI/docker-piwik
that referenced
this pull request
Mar 28, 2023
Merged
J0WI
added a commit
that referenced
this pull request
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #263