modernize

[Findus23]

While going through the code for #9 I noticed that some dependencies are outdated.

I made those changes:

• fixed Add CLI Command for system-check #8
• updated parsedown to the latest version and replaced php-markdown with parsedown
• update PHPMailer
• update to Slim 3 (and Twig), which simplified a bit of code as it supports some of the features that needed extensions out of the box.
• update github-api (and guzzle). It now uses php-cache, so any cache from this list can be used.
• new (but similar) design with bootstrap 4
• better markdown rendering (closer to how github displays it)
• fixes ability to blacklist certain types of files (eg. swf) #5 (disallow unsafe extentions)
• fixes add ability to set Piwik tracking code in footer of Github issues mirror #1 (allow piwik tracking)
• sort issues by recently updated
• add logging

Everything seems to work, but I'll need to do more testing and more cleanup.

[Findus23]

I have uploaded my version on my server, so you can compare the changes:
https://issues.lw1.at/

A small benchmark shows that the speed didn't really change:

1c1
< ➜  ~ ab -n 20 https://issues.lw1.at/8392
---
> ➜  ~ ab -n 20 https://issues.piwik.org/8392
6c6
< Benchmarking issues.lw1.at (be patient).....done
---
> Benchmarking issues.piwik.org (be patient).....done
9,10c9,10
< Server Software:        nginx/1.13.3
< Server Hostname:        issues.lw1.at
---
> Server Software:        Apache/2.2
> Server Hostname:        issues.piwik.org
12,13c12,13
< SSL/TLS Protocol:       TLSv1.2,ECDHE-RSA-AES256-GCM-SHA384,2048,256
< TLS Server Name:        issues.lw1.at
---
> SSL/TLS Protocol:       TLSv1.2,ECDHE-RSA-AES128-GCM-SHA256,2048,128
> TLS Server Name:        issues.piwik.org
16c16
< Document Length:        36974 bytes
---
> Document Length:        22346 bytes
19c19
< Time taken for tests:   5.711 seconds
---
> Time taken for tests:   6.520 seconds
22,27c22,27
< Total transferred:      744040 bytes
< HTML transferred:       739480 bytes
< Requests per second:    3.50 [#/sec] (mean)
< Time per request:       285.534 [ms] (mean)
< Time per request:       285.534 [ms] (mean, across all concurrent requests)
< Transfer rate:          127.24 [Kbytes/sec] received
---
> Total transferred:      450140 bytes
> HTML transferred:       446920 bytes
> Requests per second:    3.07 [#/sec] (mean)
> Time per request:       325.987 [ms] (mean)
> Time per request:       325.987 [ms] (mean, across all concurrent requests)
> Transfer rate:          67.42 [Kbytes/sec] received
31,34c31,34
< Connect:       80  106  59.0     83     279
< Processing:   138  179  47.3    169     295
< Waiting:      128  159  30.5    159     267
< Total:        220  285  98.7    256     574
---
> Connect:       96  100   1.7    100     104
> Processing:   138  226  67.4    214     378
> Waiting:      102  190  67.7    179     343
> Total:        237  326  67.8    315     479
37,45c37,45
<   50%    256
<   66%    259
<   75%    269
<   80%    349
<   90%    528
<   95%    574
<   98%    574
<   99%    574
<  100%    574 (longest request)
---
>   50%    315
>   66%    359
>   75%    375
>   80%    377
>   90%    441
>   95%    479
>   98%    479
>   99%    479
>  100%    479 (longest request)

[mattab]

@Findus23 Great to see your work on this project. When you're ready to deploy this ping me and we can make it happen 👍

[Findus23]

Thanks, tomorrow I’ll look over the changes again, so this should soon be ready to merge.

Any more wishes while I am working on it?

I think you’ll need to put html before htm as otherwise i think it gets partially matched.
https://regex101.com/r/O4M8h5/1

[mattab]

Another couple feature requests in case it's do-able:

• Make all URLs to piwik.org or *piwik.org or *innocraft.cloud *innocraft.com clickable links. (matching http[s]://domain*)

• On homepage, sort all issues by most recently updated so it surfaces the active issues

[Findus23]

Make all URLs to piwik.org or *piwik.org or *innocraft.cloud innocraft.com clickable links. (matching http[s]://domain)

Seems like I already fixed that. The new Markdown parser is more Github-like and automatically links all URLs in the text. (and i think href was disallowed in HTMLPurifier)
See e.g. https://issues.piwik.org/11184 and https://issues.lw1.at/11184

On homepage, sort all issues by most recently updated so it surfaces the active issues

That was an easy change (067abc9), but it means that we need to delete all data in /data/pages/

[Findus23]

@mattab, If nobody else has another suggestion, I am ready for merging.

[Findus23]

It now even works in IE 11

[mattab]

Awesome @Findus23

Deployed it on issues.piwik.org

Had to run the following commands:

  wget https://nodejs.org/dist/v6.11.2/node-v6.11.2-linux-x64.tar.gz 
  tar -xzvf node-v6.11.2-linux-x64.tar.gz 
  echo "export PATH=\$PATH:~/node-v6.11.2-linux-x64/bin" >> $HOME/.bashrc
  php composer.phar install
  npm install
  npm run compileCSS

Also updated PHP to 7.1.8