Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concurrency issue when setting custom variables #89

Closed
d4rken opened this issue Mar 17, 2016 · 3 comments
Closed

Concurrency issue when setting custom variables #89

d4rken opened this issue Mar 17, 2016 · 3 comments
Assignees
Labels

Comments

@d4rken
Copy link
Member

d4rken commented Mar 17, 2016

Seems to be very rare, happened only a few times out of a few 10k events.
Writing this down so I don't forget it :).
Maybe fix this and do #69 at the same time?

java.util.ConcurrentModificationException
        at java.util.HashMap$HashIterator.nextEntry(HashMap.java:806)
        at java.util.HashMap$EntryIterator.next(HashMap.java:843)
        at java.util.HashMap$EntryIterator.next(HashMap.java:841)
        at org.json.JSONObject.<init>(JSONObject.java:128)
        at org.piwik.sdk.CustomVariables.toString(CustomVariables.java:90)
        at org.a.a.e.a(Tracker.java:16684)
        at eu.thedarken.sdm.tools.e.a.a(PiwikHelper.java:13159)
        at eu.thedarken.sdm.tools.piwik.PiwikHelper$1.run(PiwikHelper.java:305)
        at java.lang.Thread.run(Thread.java:841)
@d4rken d4rken added the bug label Mar 17, 2016
@dotsbb
Copy link
Member

dotsbb commented Mar 18, 2016

I would like to take care of this one, if You don't mind

@d4rken
Copy link
Member Author

d4rken commented Mar 18, 2016

Sure 👍, happy hacking.

dotsbb added a commit that referenced this issue Apr 8, 2016
Change number of custom vars and fix concurrent error. Fixes #69 and #89
@d4rken
Copy link
Member Author

d4rken commented Apr 15, 2016

Fixed by @dotsbb in #90

@d4rken d4rken closed this as completed Apr 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants