Fix Device information only report for first session per process #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
injectInitialParams now handles injecting these, unless the USER_ID changes in which case they are injected by injectBaseParams Fixes matomo-org#309
An actual race here is presumably unlikely, but if it were to happen it makes more sense for all these preferences to be set together rather than alternating between multiple calls.
|
Continued in #319 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #309 this addresses the issue of the fingerprint parameters not being added for new sessions, causing "unknown" and "Generic" device information
Also there are some additional commits for minor cleanup of Tracker.java