Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release job and automatic changelog #334

Merged
merged 1 commit into from
Jul 11, 2022
Merged

Release job and automatic changelog #334

merged 1 commit into from
Jul 11, 2022

Conversation

hannesa2
Copy link
Collaborator

@hannesa2 hannesa2 commented Jul 10, 2022

A new release needs now only a new tag, eg

git tag -a 1.0 -m "text"
git push --tags

Then the release pipeline starts and generates a changelog, depended on labels of pull request.
This means a label on pull request makes sense now, if you want to see it in release changelog,

All is untested and copy&paste from https://github.com/MikeOrtiz/TouchImageView where it works like this

@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2022

Codecov Report

Merging #334 (9ed41d7) into master (37d78d7) will increase coverage by 0.07%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #334      +/-   ##
============================================
+ Coverage     86.78%   86.85%   +0.07%     
- Complexity      371      372       +1     
============================================
  Files            33       33              
  Lines          1415     1415              
  Branches        165      165              
============================================
+ Hits           1228     1229       +1     
  Misses          117      117              
+ Partials         70       69       -1     
Impacted Files Coverage Δ
...a/org/matomo/sdk/dispatcher/DefaultDispatcher.java 94.11% <0.00%> (+0.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37d78d7...9ed41d7. Read the comment docs.

Copy link
Member

@d4rken d4rken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat, looking forward to see the changelog generator in action 😎.

One small question, see comment.

.github/workflows/release.yml Outdated Show resolved Hide resolved
@Findus23
Copy link
Member

Something like matomo-org/matomo#17809 might also be useful here

@hannesa2
Copy link
Collaborator Author

Because I want to test it, I introduce a pre-release ability

@hannesa2
Copy link
Collaborator Author

Because I want to test it, I introduce a pre-release ability

Pre-relase is working, but changelog not

@hannesa2 hannesa2 force-pushed the releaseJob branch 2 times, most recently from 11b4a87 to 49cde38 Compare July 10, 2022 18:00
@hannesa2
Copy link
Collaborator Author

I made a test release https://github.com/hannesa2/matomo-sdk-android/releases in my fork, and there at least, it was working

Copy link
Member

@d4rken d4rken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it only work for master maybe?

@hannesa2
Copy link
Collaborator Author

Does it only work for master maybe?

No, it works on a branch as well. Even pull request with merge commit and pull request with rebased commit.
image

Here are my tests https://github.com/hannesa2/matomo-sdk-android/releases

I've no clue, why the tests in this repository where without changelog. Maybe merge it and lighten a candle that next time on real release it will work on this repo as well ?

@hannesa2
Copy link
Collaborator Author

I removed the pre-release because it can't show tag in caption
image

Now it works like this gain. But without the pre-release ability
image

Please see my tests https://github.com/hannesa2/matomo-sdk-android/releases

@d4rken d4rken merged commit 6ba5975 into master Jul 11, 2022
@d4rken d4rken deleted the releaseJob branch July 11, 2022 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants