Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minSdk 19 #335

Merged
merged 1 commit into from
Jul 10, 2022
Merged

minSdk 19 #335

merged 1 commit into from
Jul 10, 2022

Conversation

hannesa2
Copy link
Collaborator

It's related to #323 (comment)

@codecov-commenter
Copy link

Codecov Report

Merging #335 (c5b4b9a) into master (7216a32) will increase coverage by 0.53%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #335      +/-   ##
============================================
+ Coverage     86.24%   86.78%   +0.53%     
  Complexity      371      371              
============================================
  Files            33       33              
  Lines          1425     1415      -10     
  Branches        167      165       -2     
============================================
- Hits           1229     1228       -1     
+ Misses          125      117       -8     
+ Partials         71       70       -1     
Impacted Files Coverage Δ
...c/main/java/org/matomo/sdk/tools/DeviceHelper.java 75.00% <100.00%> (+15.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7216a32...c5b4b9a. Read the comment docs.

Copy link
Member

@d4rken d4rken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@d4rken d4rken merged commit 79b0f73 into master Jul 10, 2022
@d4rken d4rken deleted the minSdk19 branch July 10, 2022 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants