Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog created by github #359

Merged
merged 1 commit into from
Jul 21, 2022
Merged

Changelog created by github #359

merged 1 commit into from
Jul 21, 2022

Conversation

hannesa2
Copy link
Collaborator

@d4rken d4rken merged commit 56b0791 into master Jul 21, 2022
@d4rken d4rken deleted the ChangelogByGithub branch July 21, 2022 20:44
@d4rken
Copy link
Member

d4rken commented Jul 21, 2022

That looks really nice, cool ❤️

https://github.com/d4rken/android-starter-v4/releases/tag/v4.4.1

I love that it adds the little contributor icons to the bottom an mentions who authored a PR 🍻

@hannesa2
Copy link
Collaborator Author

This should here no more necessary
image

Btw, I vote to remove the v from the git tag

@hannesa2
Copy link
Collaborator Author

Btw, you already tested it, please can you test it with @v1 again ?

    uses: softprops/action-gh-release@v1

I'm not sure about the versioning there, and dependabot will make this pull request soon but the test needs to be done manually

@d4rken
Copy link
Member

d4rken commented Jul 22, 2022

This should here no more necessary

Not for the changelog but I like to keep it in sync (even for my demo project 😁).

Btw, you already tested it, please can you test it with @v1 again ?

Will do.

Btw, I vote to remove the v from the git tag

I like that you can filter things like release creation v* and keeping it the same as it is might be easier for existing users.
But I don't feel too strongly about it, if this is important for you feel free to change it ☕

@d4rken
Copy link
Member

d4rken commented Jul 22, 2022

Looks okay with @v1 too
https://github.com/d4rken/android-starter-v4/releases/tag/v4.4.1-rc1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants