Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Legacy Build System #391

Merged
merged 1 commit into from Sep 25, 2021
Merged

Conversation

sieren
Copy link
Contributor

@sieren sieren commented Aug 23, 2021

Remove the legacy build system for the xcworkspace
so the sdk builds (via carthage) using xcode 13.

Closes #390

@sieren sieren changed the title Use new build system Remove Legacy Build System Aug 23, 2021
@sieren
Copy link
Contributor Author

sieren commented Sep 20, 2021

@brototyp anything else you need from me here? The failing travis build seems unrelated to this PR

@brototyp
Copy link
Member

@brototyp anything else you need from me here? The failing travis build seems unrelated to this PR

Hey @sieren, thanks for creating the PR for your patience and pinging me. Can you do me a favor an rebase this pr onto develop? That should fix the build issues. The only thing left then would be a small entry to the CHANGELOG.md.

Remove the legacy build system for the xcworkspace
so the sdk builds (via carthage) using xcode 13.
@sieren
Copy link
Contributor Author

sieren commented Sep 21, 2021

@brototyp thanks :) just force pushed the changes and rebased onto develop.

@sieren
Copy link
Contributor Author

sieren commented Sep 22, 2021

@brototyp still fails but this might be due to something else now?

@brototyp
Copy link
Member

Hm. Interesting. It looks like danger can't find the branch because it is in your fork. I'll check it out to see if that's something we can fix.

@sieren
Copy link
Contributor Author

sieren commented Sep 22, 2021

Worst case you can also just re-open a new PR and cherry-pick my commit onto a matomo hosted branch. I wouldn't mind ;)

@brototyp brototyp merged commit b84105c into matomo-org:develop Sep 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Legacy Build System errors out in Xcode 13 Beta
2 participants