Skip to content

Commit

Permalink
refs #5019 using the cache reduced the time spent in tracking (piwik.…
Browse files Browse the repository at this point in the history
…php) from 2seconds to 200ms (on my local env)
  • Loading branch information
tsteur committed May 25, 2014
1 parent 6e134df commit 075e6ba
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions core/Tracker/Settings.php
Expand Up @@ -8,7 +8,7 @@
*/
namespace Piwik\Tracker;


use Piwik\CacheFile;
use Piwik\Tracker;

class Settings
Expand Down Expand Up @@ -37,11 +37,12 @@ protected function loadInfo()
$userAgent = $this->request->getUserAgent();

$deviceDetector = new \DeviceDetector($userAgent);
$deviceDetector->setCache(new CacheFile('tracker', 86400));
$deviceDetector->parse();
$aBrowserInfo = $deviceDetector->getBrowser();

$browserName = !empty($aBrowserInfo['short_name']) ? $aBrowserInfo['short_name'] : 'UNK';
$browserVersion = !empty($aBrowserInfo['version']) ? $aBrowserInfo['version'] : '';
$browserVersion = !empty($aBrowserIntfo['version']) ? $aBrowserInfo['version'] : '';

$os = $deviceDetector->getOS();
$os = empty($os['short_name']) ? 'UNK' : $os['short_name'];
Expand Down

0 comments on commit 075e6ba

Please sign in to comment.