Refactor magic string FTW

core/FrontController.php

@@ -57,6 +57,7 @@
 class FrontController extends Singleton
 {
     const DEFAULT_MODULE = 'CoreHome';
+
     /**
      * Set to false and the Front Controller will not dispatch the request
      *
@@ -153,7 +154,8 @@ protected function makeController($module, $action, &$parameters)
             return array(new CoreHomeController(), 'renderReportWidget');
         }
 
-        if (!empty($action) && 'menu' === substr($action, 0, 4)) {
+        if (!empty($action) && Report::PREFIX_ACTION_IN_MENU === substr($action, 0, strlen(Report
+            ::PREFIX_ACTION_IN_MENU))) {
             $reportAction = lcfirst(substr($action, 4)); // menuGetPageUrls => getPageUrls
             $report       = Report::factory($module, $reportAction);
 

core/Plugin/Report.php

@@ -41,6 +41,12 @@ class Report
      */
     const COMPONENT_SUBNAMESPACE = 'Reports';
 
+    /**
+     * When added to the menu, a given report eg 'getCampaigns'
+     * will be routed as &action=menuGetCampaigns
+     */
+    const PREFIX_ACTION_IN_MENU = 'menu';
+
     /**
      * The name of the module which is supposed to be equal to the name of the plugin. The module is detected
      * automatically.
@@ -711,7 +717,7 @@ private function getMetricTranslations($metricsToTranslate)
 
     private function getMenuControllerAction()
     {
-        return 'menu' . ucfirst($this->action);
+        return self::PREFIX_ACTION_IN_MENU . ucfirst($this->action);
     }
 
     private function getSubtableApiMethod()

plugins/Contents/Controller.php

@@ -27,7 +27,7 @@ public function index()
             $reportsView->addReport(
                 $report->getCategory(),
                 $report->getName(),
-                'Contents.menu' . ucfirst($report->getAction())
+                'Contents.' . Report::PREFIX_ACTION_IN_MENU . ucfirst($report->getAction())
             );
         }