Skip to content

Commit

Permalink
Fixes #2664
Browse files Browse the repository at this point in the history
 * Sort goal table by conversion desc by default (instead of visits)
 * Add "Goal" introduction text (in hardcoded english  but maybe could be translated (is everybody happy with the help text?)

git-svn-id: http://dev.piwik.org/svn/trunk@5236 59fd770c-687e-43c8-a1e3-f5a4ff64c105
  • Loading branch information
mattab committed Sep 27, 2011
1 parent c91c513 commit 419b316
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 2 deletions.
8 changes: 7 additions & 1 deletion core/ViewDataTable/HtmlTable/Goals.php
Expand Up @@ -78,7 +78,6 @@ public function main()
'goal_%s_nb_conversions',
'goal_%s_conversion_rate',
'goal_%s_revenue_per_visit',

'revenue_per_visit',
));
}
Expand All @@ -91,6 +90,13 @@ public function main()
{
$this->setSortedColumn('nb_visits', 'desc');
}

$columnNbConversionsCurrentGoal = $columnsToDisplay[2];
if($this->processOnlyIdGoal > 0
&& strpos($columnNbConversionsCurrentGoal, '_nb_conversions') !== false)
{
$this->setSortedColumn($columnNbConversionsCurrentGoal, 'desc');
}
parent::main();
}

Expand Down
2 changes: 1 addition & 1 deletion lang/en.php
Expand Up @@ -647,7 +647,7 @@
'Goals_CaseSensitive' => 'Case sensitive match',
'Goals_Pattern' => 'Pattern',
'Goals_ExceptionInvalidMatchingString' => 'If you choose \'exact match\', the matching string must be a URL starting with %s. For example, \'%s\'.',
'Goals_LearnMoreAboutGoalTrackingDocumentation' => 'Learn more about %s Tracking Goals in Piwik%s in the user documentation.',
'Goals_LearnMoreAboutGoalTrackingDocumentation' => 'Learn more about %s Tracking Goals in Piwik%s in the user documentation, or create a Goal now!',
'Goals_ProductSKU' => 'Product SKU',
'Goals_ProductName' => 'Product Name',
'Goals_ProductCategory' => 'Product Category',
Expand Down
3 changes: 3 additions & 0 deletions plugins/Goals/templates/add_edit_goal.tpl
@@ -1,5 +1,8 @@
{if isset($onlyShowAddNewGoal)}
<h2>{'Goals_AddNewGoal'|translate}</h2>
<p>Goal Conversion tracking is one of the most efficient ways to measure and improve your business objectives.</p>
<p>A Goal in Piwik is your strategy, your priority, and can entail many things: "Downloaded brochure", "Registered newsletter", "Visited page services.html", etc. What do you want your users to do on your website?
You will be able to view and analyse your performance for each Goal, and learn how to increase conversions, conversion rates and revenue per visit.</p>
<p>{'Goals_LearnMoreAboutGoalTrackingDocumentation'|translate:"<a href='?module=Proxy&action=redirect&url=http://piwik.org/docs/tracking-goals-web-analytics/' target='_blank'>":"</a>"}
</p>
{else}
Expand Down

0 comments on commit 419b316

Please sign in to comment.