Skip to content

Commit

Permalink
Merge pull request #76 from digital11/master
Browse files Browse the repository at this point in the history
IE8 Script error in segmentation - Kuddos @digital11
  • Loading branch information
Matthieu Aubry committed Jun 2, 2013
2 parents 2bf8b29 + e405e21 commit 500e29f
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions plugins/SegmentEditor/templates/Segmentation.js
Expand Up @@ -185,9 +185,9 @@ Segmentation = (function($) {

var getSegmentFromId = function (id) {
if(self.availableSegments.length > 0) {
for(var key in self.availableSegments)
for(var i = 0; i < self.availableSegments.length; i++)
{
segment = self.availableSegments[key];
segment = self.availableSegments[i];
if(segment.idsegment == id) {
return segment;
}
Expand All @@ -206,9 +206,9 @@ Segmentation = (function($) {
+ ' ' + self.translations['General_DefaultAppended']
+ '</span></li> ';
if(self.availableSegments.length > 0) {
for(var key in self.availableSegments)
for(var i = 0; i < self.availableSegments.length; i++)
{
segment = self.availableSegments[key];
segment = self.availableSegments[i];
injClass = "";
if( segment.definition == self.currentSegmentStr){
injClass = 'class="segmentSelected"';
Expand Down Expand Up @@ -247,9 +247,9 @@ Segmentation = (function($) {
+ '">' + self.translations['SegmentEditor_AddNewSegment']
+ '</option>';
segmentsDropdown.append(newOption);
for(var key in self.availableSegments)
for(var i = 0; i < self.availableSegments.length; i++)
{
segment = self.availableSegments[key];
segment = self.availableSegments[i];
newOption = '<option data-idsegment="'+segment.idsegment+'" data-definition="'+(segment.definition).replace(/"/g, '&quot;')+'" title="'+segment.name+'">'+self.shortenSegmentName(segment.name)+'</option>';
segmentsDropdown.append(newOption);
}
Expand Down

0 comments on commit 500e29f

Please sign in to comment.