refs #4053 simplify getInfoOfPluginsHavingUpdate

matomo-org · Sep 22, 2013 · 97cb6e6 · 97cb6e6
1 parent be865ff
commit 97cb6e6
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 28 deletions.
diff --git a/plugins/CorePluginsAdmin/Marketplace.php b/plugins/CorePluginsAdmin/Marketplace.php
@@ -83,11 +83,7 @@ public function getPluginsHavingUpdate($themesOnly)
         $loadedPlugins = $pluginManager->getLoadedPlugins();
 
         try {
-            if ($themesOnly) {
-                $pluginsHavingUpdate = $this->client->getInfoOfThemesHavingUpdate($loadedPlugins);
-            } else {
-                $pluginsHavingUpdate = $this->client->getInfoOfPluginsHavingUpdate($loadedPlugins);
-            }
+            $pluginsHavingUpdate = $this->client->getInfoOfPluginsHavingUpdate($loadedPlugins, $themesOnly);
 
         } catch (\Exception $e) {
             $pluginsHavingUpdate = array();

diff --git a/plugins/CorePluginsAdmin/MarketplaceApiClient.php b/plugins/CorePluginsAdmin/MarketplaceApiClient.php
@@ -83,10 +83,11 @@ public function checkUpdates($plugins)
     }
 
     /**
-     * @param \Piwik\Plugin[] $plugins
+     * @param  \Piwik\Plugin[] $plugins
+     * @param  bool            $themesOnly
      * @return array
      */
-    public function getInfoOfPluginsHavingUpdate($plugins)
+    public function getInfoOfPluginsHavingUpdate($plugins, $themesOnly)
     {
         $hasUpdates = $this->checkUpdates($plugins);
 
@@ -95,27 +96,7 @@ public function getInfoOfPluginsHavingUpdate($plugins)
         foreach ($hasUpdates as $pluginHavingUpdate) {
             $plugin = $this->getPluginInfo($pluginHavingUpdate->name);
 
-            if (empty($plugin->isTheme)) {
-                $pluginDetails[] = $plugin;
-            }
-        }
-
-        return $pluginDetails;
-    }
-
-    /**
-     * @param \Piwik\Plugin[] $plugins
-     * @return array
-     */
-    public function getInfoOfThemesHavingUpdate($plugins)
-    {
-        $hasUpdates = $this->checkUpdates($plugins);
-
-        $pluginDetails = array();
-        foreach ($hasUpdates as $pluginHavingUpdate) {
-            $plugin = $this->getPluginInfo($pluginHavingUpdate->name);
-
-            if (!empty($plugin->isTheme)) {
+            if (!empty($plugin->isTheme) == $themesOnly) {
                 $pluginDetails[] = $plugin;
             }
         }