Avoid calling the same method twice

matomo-org · Mar 16, 2015 · a7a8c71 · a7a8c71
1 parent d3e92fa
commit a7a8c71
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/core/Plugin/Menu.php b/core/Plugin/Menu.php
@@ -78,11 +78,12 @@ protected function urlForDefaultAction($additionalParams = array())
      */
     protected function urlForAction($controllerAction, $additionalParams = array())
     {
-        $this->checkisValidCallable($this->getModule(), $controllerAction);
+        $module = $this->getModule();
+        $this->checkisValidCallable($module, $controllerAction);
 
         $params = (array) $additionalParams;
         $params['action'] = $controllerAction;
-        $params['module'] = $this->getModule();
+        $params['module'] = $module;
 
         return $params;
     }