refs #6661 added a test to make sure it works

matomo-org · Nov 13, 2014 · d0929e8 · d0929e8
1 parent 1430870
commit d0929e8
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 3 deletions.
diff --git a/core/Tracker.php b/core/Tracker.php
@@ -669,7 +669,8 @@ private function sendResponse()
         $request = $_GET + $_POST;
 
         if (array_key_exists('send_image', $request) && $request['send_image'] === '0') {
-            Common::sendHeader("HTTP/1.1 204 No Response");
+            Common::sendResponseCode(204);
+
             return;
         }
 

diff --git a/tests/PHPUnit/Framework/Constraint/ResponseCode.php b/tests/PHPUnit/Framework/Constraint/ResponseCode.php
@@ -9,6 +9,7 @@
 
 class ResponseCode extends \PHPUnit_Framework_Constraint
 {
+    private $actualCode;
 
     /**
      * @param integer $value Expected response code
@@ -41,7 +42,9 @@ public function matches($other)
         $responseCode = curl_getinfo($ch, CURLINFO_HTTP_CODE);
         curl_close($ch);
 
-        return $this->value === (int) $responseCode;
+        $this->actualCode = (int) $responseCode;
+
+        return $this->value === $this->actualCode;
     }
 
     /**
@@ -51,6 +54,6 @@ public function matches($other)
      */
     public function toString()
     {
-        return 'does not return response code ' . $this->exporter->export($this->value);
+        return 'does not return response code ' . $this->exporter->export($this->value) . ' it is ' . $this->actualCode;
     }
 }?>
diff --git a/tests/PHPUnit/System/TrackerTest.php b/tests/PHPUnit/System/TrackerTest.php
@@ -69,4 +69,12 @@ public function test_response_ShouldSend204ResponseCode_IfImageIsDisabled()
         $this->assertResponseCode(204, $url);
     }
 
+    public function test_response_ShouldSend400ResponseCode_IfSiteIdIsInvalid()
+    {
+        $url = $this->tracker->getUrlTrackPageView('Test');
+        $url .= '&idsite=100';
+
+        $this->assertResponseCode(400, $url);
+    }
+
 }