Skip to content

Commit

Permalink
Fixes #1899, disable row actions for Referrers.getAll, since efficien…
Browse files Browse the repository at this point in the history
…tly setting subtables for DataTable_Array children is nontrivial.
  • Loading branch information
Benaka Moorthi committed Feb 4, 2013
1 parent f68d3c3 commit d482aea
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
5 changes: 1 addition & 4 deletions plugins/Referers/API.php
Expand Up @@ -486,10 +486,7 @@ private function setGetReferrerTypeSubtables( $dataTable, $idSite, $period, $dat
{
if ($dataTable instanceof Piwik_DataTable_Array) // recurse for array datatables
{
foreach ($dataTable->getArray() as $childTable)
{
$this->setGetReferrerTypeSubtables($childTable, $idSite, $period, $date, $segment, $expanded);
}
throw new Exception("Referrers.getAll with multiple sites or dates is not supported (yet).");
}
else
{
Expand Down
1 change: 1 addition & 0 deletions plugins/Referers/Controller.php
Expand Up @@ -149,6 +149,7 @@ public function getAll( $fetch = false )
$view->setColumnsToDisplay(array('label', 'nb_visits'));
$view->enableShowGoals();
$view->setLimit(20);
$view->setCustomParameter('disable_row_actions', '1');

$setGetAllHtmlPrefix = array($this, 'setGetAllHtmlPrefix');
$view->queueFilter(
Expand Down

0 comments on commit d482aea

Please sign in to comment.