Skip to content

Commit

Permalink
Fixes #5370 Set $priority to false, so that the column is processed l…
Browse files Browse the repository at this point in the history
…ater on when the summary row is available.

ping @tsteur - upcoming merge fail
  • Loading branch information
mattab committed Jun 20, 2014
1 parent 9ec4bca commit d7b2e4a
Showing 1 changed file with 23 additions and 5 deletions.
28 changes: 23 additions & 5 deletions plugins/DBStats/DBStats.php
Expand Up @@ -115,7 +115,13 @@ private function configureViewForGetDatabaseUsageSummary(ViewDataTable $view)
: $value;
};

$view->config->filters[] = array('ColumnCallbackReplace', array('label', $translateSummaryLabel), $isPriority = true);
$view->config->filters[] = array('ColumnCallbackReplace',
array(
'label',
$translateSummaryLabel
),
$isPriority = true
);
}

private function configureViewForGetTrackerDataSummary(ViewDataTable $view)
Expand Down Expand Up @@ -256,7 +262,13 @@ private function addPresentationFilters(ViewDataTable $view, $addTotalSizeColumn
};

$view->config->filters[] = array('ColumnCallbackAddColumn',
array(array('data_size', 'index_size'), 'total_size', $getTotalTableSize), $isPriority = true);
array(
array('data_size', 'index_size'),
'total_size',
$getTotalTableSize
),
$isPriority = true
);

$sizeColumns[] = 'total_size';
}
Expand All @@ -273,9 +285,15 @@ private function addPresentationFilters(ViewDataTable $view, $addTotalSizeColumn
&& $addTotalSizeColumn
) {
$view->config->filters[] = array('ColumnCallbackAddColumnPercentage',
array('percent_total', 'total_size', 'total_size', $quotientPrecision = 0,
$shouldSkipRows = false, $getDivisorFromSummaryRow = true),
$isPriority = true
array(
'percent_total',
'total_size',
'total_size',
$quotientPrecision = 0,
$shouldSkipRows = false,
$getDivisorFromSummaryRow = true
),
$isPriority = false
);

$view->requestConfig->filter_sort_column = 'percent_total';
Expand Down

0 comments on commit d7b2e4a

Please sign in to comment.