Skip to content

Commit

Permalink
Refs #3697, Prettify ISP names
Browse files Browse the repository at this point in the history
  • Loading branch information
Kévin Subileau committed Mar 17, 2013
1 parent 51b7787 commit e5dee0a
Show file tree
Hide file tree
Showing 3 changed files with 36 additions and 2 deletions.
2 changes: 1 addition & 1 deletion plugins/Live/Visitor.php
Expand Up @@ -497,7 +497,7 @@ function getScreenTypeIcon()

function getProvider()
{
return Piwik_getHostnameName( @$this->details['location_provider']);
return Piwik_Provider_getPrettyProviderName( @$this->details['location_provider']);
}

function getProviderUrl()
Expand Down
2 changes: 1 addition & 1 deletion plugins/Provider/API.php
Expand Up @@ -39,7 +39,7 @@ public function getProvider( $idSite, $period, $date, $segment = false )
$dataTable = $archive->getDataTable('Provider_hostnameExt');
$dataTable->filter('Sort', array(Piwik_Archive::INDEX_NB_VISITS));
$dataTable->queueFilter('ColumnCallbackAddMetadata', array('label', 'url', 'Piwik_getHostnameUrl'));
$dataTable->queueFilter('ColumnCallbackReplace', array('label', 'Piwik_getHostnameName'));
$dataTable->queueFilter('ColumnCallbackReplace', array('label', 'Piwik_Provider_getPrettyProviderName'));
$dataTable->queueFilter('ReplaceColumnNames');
$dataTable->queueFilter('ReplaceSummaryRowLabel');
return $dataTable;
Expand Down
34 changes: 34 additions & 0 deletions plugins/Provider/functions.php
Expand Up @@ -61,3 +61,37 @@ function Piwik_getHostnameUrl($in)
return "https://startpage.com/do/search?q=".urlencode($in);
}
}

/**
* Return a pretty provider name for a given domain name
*
* @param string $in hostname
* @return string Real ISP name, IP (if IP address didn't resolve), or Unknown
*/
function Piwik_Provider_getPrettyProviderName( $in )
{
$providerName = Piwik_getHostnameName($in);

$prettyNames = array( //List to be completed
// France
"wanadoo" => "Orange",
"proxad" => "Free",
"bbox" => "Bouygues Telecom",
"bouyguestelecom" => "Bouygues Telecom",
"coucou-networks" => "Free Mobile",
"sfr" => "SFR", //Acronym, keep in uppercase
"univ-metz" => "Université de Lorraine",
"unilim" => "Université de Limoges",
"univ-paris5" => "Université Paris Descartes",

// US
"rr" => "Time Warner Cable Internet", // Not sure
);

if(array_key_exists(strtolower($providerName), $prettyNames))
{
$providerName = $prettyNames[strtolower($providerName)];
}

return $providerName;
}

0 comments on commit e5dee0a

Please sign in to comment.