Skip to content

Commit

Permalink
Show actions without url in visitor log (#12191)
Browse files Browse the repository at this point in the history
* Handle actions with title only correctly

* use action with empty url for tests

* update expected ui files
  • Loading branch information
sgiehl authored and mattab committed Nov 19, 2017
1 parent ca0a9aa commit e6b5f33
Show file tree
Hide file tree
Showing 7 changed files with 8 additions and 0 deletions.
2 changes: 2 additions & 0 deletions plugins/Actions/VisitorDetails.php
Expand Up @@ -100,6 +100,7 @@ public function provideActionsForVisit(&$actions, $visitorDetails)
private function shouldHandleAction($action) {
$actionTypesToHandle = array(
Action::TYPE_PAGE_URL,
Action::TYPE_PAGE_TITLE,
Action::TYPE_SITE_SEARCH,
Action::TYPE_EVENT,
Action::TYPE_OUTLINK,
Expand Down Expand Up @@ -165,6 +166,7 @@ public function extendActionDetails(&$action, $nextAction, $visitorDetails)
$action['icon'] = 'plugins/Morpheus/images/search_ico.png';
break;
case Action::TYPE_PAGE_URL:
case Action::TYPE_PAGE_TITLE:
case '':
$action['type'] = 'action';
$action['icon'] = null;
Expand Down
Expand Up @@ -204,6 +204,12 @@ private function trackVisitMediaPlayer(\PiwikTracker $t, $dateTime)
$t->setForceVisitDateTime(Date::factory($dateTime)->addHour(0.4)->getDatetime());
$t->addEcommerceItem('F4NCYX', 'fancy product', 'software', $price = 40, $qty = 3);
self::checkResponse($t->doTrackEcommerceCartUpdate(120));

$t->setForceVisitDateTime(Date::factory($dateTime)->addHour(0.6)->getDatetime());
$t->setUrl('');
$t->setGenerationTime(156);
$t->setDebugStringAppend('bw_bytes=1254');
self::checkResponse($t->doTrackPageView('Action without url'));
}

private function trackDeviceVisit(\PiwikTracker $t, $dateTime, $useragent)
Expand Down
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit e6b5f33

Please sign in to comment.