-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read Environment variables into Matomo config #10914
Comments
This would be useful for passwords etc. For other config there is some "danger" that config is not the same on all servers which causes Piwik to not work properly etc but for passwords it would be useful for sure |
Yes 12 factor support (environment var injection) for all the variables that happen at config would be really useful. That would allow us to run dev/staging piwik containers on the same hosts pointing to separate DBs etc. |
For configuration |
Secrets are not a clear definition, because the domain of trust needs to be known. Often secrets contained to the environment is good enough so trying to protect processes from each other is overkill. Other times not leaking to the underlying system is critical. The solution and the controls it offers needs to be assessed with the risk and against relevant attack trees. So for example using something like credstash in the container runtime to inject sensitive vars is good enough for many use cases as it is separating the management of the app from the management of the environment it is running in. |
This would specifically be useful for deploying Piwik on cloud-based platforms with ephemeral filesystems that don't persist file changes across deploys / restarts, such as Cloud Foundry or Heroku. |
Any advance regarding this? |
Not yet Update Oct 29th: scheduling this issue |
Hi @pierreozoux @vfbsilva @SonOfBytes |
I think it could be useful for pretty much all settings. Take Grafana for instance... all settings can be set by env variable: http://docs.grafana.org/installation/configuration/#using-environment-variables |
FYI: I've implemented to read database config from environment variables optionally during installation see #13676 To read any other variables during runtime basically I suggest someone could work on a plugin. I might quickly have a look if that plugin can be easily developed. |
Was quick to build... maybe someone give https://github.com/matomo-org/plugin-EnvironmentVariables a test and then we could publish it on the marketplace. I haven't really tested it myself. |
Wow :) amazing ;) Https://12factor.net ftw! |
Hi @pierreozoux I'm closing this as done as AFAIK @baywet is using it for a private project and it was working 🎉 |
Hey @mattab I am testing this just know as I want to get matomo running in a cloud foundry environment (on bluemix). I added the Plugin to my project and installed it to my plugin folder. For now the default CF variable names seem not to be supported so I set them on my own with the app. However the first deployment shows me now: SQLSTATE[HY000] [2002] No such file or directory Not sure if really works. I will dig deeper into it. Best |
@ZuSe |
we need matomo to support env variables natively, not using another plugin. |
Modern web application read their config from env variables.
https://12factor.net/config
it would be a really nice to have :)
The text was updated successfully, but these errors were encountered: