-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update davaxi/sparkline composer dependency #15458
Comments
@diosmosis should know best about it but I have no idea why this fails. While we should now be using the latest upstream (#15465), the branch still exists and should therefore work in composer (https://github.com/matomo-org/Sparkline/tree/multiple-series) |
Maybe caused by a composer setting? I'm not sure why this would fail. |
I can reproduce the issue. Not sure why it doesn't work though or how it needs to be configured etc. It looks like we used to use 1.1 so we could change it to 1.2 or so? |
I've created PRs to update that, but actually the latest release has
another bug, that produces warnings on PHP 5 and an error on PHP 7. Created
a PR to fix it in the lib. Hope it gets merged soon and a new version is
released, so we can update it...
… |
@sgiehl looks like a new release maybe coming next week davaxi/Sparkline#15 (comment) |
Currently
davaxi/sparkline
is set to the versiondev-multiple-series
incomposer.json
matomo/composer.json
Line 51 in 5322d05
This results in the following error when running
composer require piwik/piwik
I believe
davaxi/sparkline
should instead be set to~1.2
, to install the latest release that includes the changes merged to support displaying multiple series.The text was updated successfully, but these errors were encountered: