-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically comment on PRs after inactivity #17344
Comments
Any thoughts @mattab @sgiehl @flamisz @diosmosis ? |
@tsteur the action I recommended can comment and add a label on the pr or issue first, and closing later (can setup how many days of inactivity triggers what). Lots of options. |
For this case we could even use an GitHub App instead of an action. e.g. https://probot.github.io/apps/stale/ |
@flamisz great that it could comment first say after 2 weeks and then close after 6 weeks. Does this time start from PR creation? Is there any chance to only start the time measurement for example from the time So far it says |
We currently have three actions to mark stale issues and ping core reviewers on PRs that need review and didn't have activity for some time. I think the current set works ok for us at this stage. but it's also possible to add the automatic PR close, the Is there something we want to do at the moment or can we close this, @matomo-org/core-reviewers / @tsteur? |
I'd vote for closing this one for now. We can at a later point disucss further changes/improvements when we see any need for it. |
see #17318 (comment)
In #17318 we're discussing about following up automatically when a PR has been waiting for a review for too long. This issue is about automatically following up when we're waiting for the PR author.
We could maybe follow up with (community) PRs automatically if they have been inactive for a while for example when we're waiting for changes for say 2 weeks or more.
After 6 weeks we could close the PR and remind the PR author that we'll reopen the PR again once work continues etc.
so far we have this message for when a PR is more than 1 month old: https://github.com/matomo-org/matomo/wiki/Triage-the-issue-trackers#pull-request-more-than-1-month-old
This logic would ideally also apply to our own PRs but we'd need to have a custom label that we can assign to ignore this logic as sometimes we want to keep a PR open for longer.
I wonder though how we'd know if a PR is inactive for too long? I suppose it would be if there PR was last marked as
Review: Changes requested
and there hasn't been a commit since then?@flamisz recommended https://github.com/actions/stale https://github.com/marketplace/actions/close-stale-issues for closing the issues automatically. We'd also want to comment automatically though.
fyi @mattab
The text was updated successfully, but these errors were encountered: