-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CustomVariables and Provider can be uninstalled unexpectedly #18411
Comments
It's on purpose that they can meanwhile be uninstalled, as they shouldn't be shipped with the Matomo release anymore. The last release included them by accident I guess. |
I just assured, and the integrity check failures when uninstalling CustomVariables is still present with this release:
|
Original issue is solved with v4.6.1, many thanks 👍. However, the integrity check now fails because of other falsely present files 😄:
|
@MichaIng Those files had been part of some previous releases or rcs. Should be safe to delete them. |
Ah, I haven't considered that previous releases may have shipped those while 4.6.1 may have undergone some cleanup. Yes those are mostly build and lint configurations, so not required for production. I removed them and didn't face any issue so far. I'll close the issue then as solved. |
The CustomVariables and Provider plugins can be uninstalled even that they are reinstalled with every Matomo update. Furthermore, the CustomVariables plugin uninstall causes integrity check errors on the system check page.
Expected Behavior
All plugins which are shipped with the Matomo core/update should not be uninstallable. All plugins which can be uninstalled, should not cause integrity check errors when doing so.
Current Behavior
I'll only repeat myself 😄.
Possible Solution
Either mark those two plugins as not uninstallable, or assure that they are not reinstalled with updates and do not cause integrity check errors.
Steps to Reproduce (for Bugs)
Context
Your Environment
The text was updated successfully, but these errors were encountered: