-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Config-Hook #2524
Comments
Actually I ment Zend_Registry::isRegistered('config') |
createConfigObject() is called before plugins are loaded. How do you load your config? |
Actually at the moment I'm loading the config how piwik it does by default. Therefor I think it would be best to check if 'config' is already in Zend_Registry, and, if so, not loading the piwik-config.... |
Please submit a patch for this feature to be considered :) we will reopen when a patch submitted, thanks! |
Like I said, we load the config before plugins are loaded. Your plugin can certainly override it, but it looks like there's a chicken-and-egg problem adding a hook in core. |
Well the problem is, that no plugin is loaded, if the database-configuration is not correct. Actually every developer has it's own mashine including mysql. Therefor it's necessary either to make plugins loaded before any database-connection is established, or, as I said, make it possible to set 'config'-registry-entry e.g. in bootstrap.php, which I can use since I saw it in index.php. |
In our company we have global config-files, which are different on every developer-vm. therefor it would be nice, if there would be an
Zend_Registry::isRegistered('conf') in Piwik::createConfigObject before setting it. No great deal, but big effect ;)
Keywords: zend_config, isregistered
The text was updated successfully, but these errors were encountered: