Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify / improve top menu #5192

Closed
tsteur opened this issue May 19, 2014 · 17 comments
Closed

Simplify / improve top menu #5192

tsteur opened this issue May 19, 2014 · 17 comments
Assignees
@tsteur
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Milestone
2.4.0

Comments

@tsteur
Copy link
Member

tsteur commented May 19, 2014

As part of making the UI cleaner we can simplify the top menu which lists the dashboard, help, settings, username, ...

Currently the menu is separated in two parts. We can "merge" those two menus together and hide some links in a submenu or even "remove" some links. For instance "Widgets" and "API" are used very rarely.

Idea would be

- Dashboard
- All Websites Dashboard
- Email & Sms reports
- Alerts
- Username (eg root)
  + Widgets
  + API
  + -------
  + Settings
  + Help
  + Logout

As the "Email & sms reports" and "Alerts" are user related (each user creates its own alerts / reports) we could display them in the user menu as well and have an even simpler navigation:

- Dashboard
- All Websites Dashboard
- Username (eg root)
  + Settings
  + -------
  + Email & Sms reports
  + Alerts
  + -------
  + Widgets
  + API
  + -------
  + Help
  + Logout

This lets the user focus on analyzing data.

The user menu would also allow 3rd party plugins to add links as the top menu already does. In the future we can add links like "Report a bug" and "Give feedback".

- Dashboard
- All Websites Dashboard
- 3rd PARTY LINKS
- Username (eg root)
  + Settings
  + -------
  + Email & Sms reports
  + Alerts
  + 3rd PARTY LINKS
  + -------
  + Widgets
  + API
  + -------
  + Help
  + Report a bug
  + Give feedback
- Logout

Any thoughts?

See also discussion at #4987
@tsteur
Copy link
Member Author

tsteur commented May 20, 2014

In 009a6f2: refs #5192 starting a little Menu refactoring

@tsteur
Copy link
Member Author

tsteur commented May 20, 2014

In b2cb622: refs #5192 continued menu refactoring. not sure yet how good this idea is but seems to be already better than before

@tsteur
Copy link
Member Author

tsteur commented May 20, 2014

In 45ae10e: refs #5192 introducing a user menu

@tsteur
Copy link
Member Author

tsteur commented May 20, 2014

In 307ec31: refs #5192 added generator for menus, updated more plugins to use menu class, fixed some bugs, improved design, fixed tests, ...

@tsteur
Copy link
Member Author

tsteur commented May 20, 2014

In 056e8ef: refs #5192 display category name in menu

@tsteur
Copy link
Member Author

tsteur commented May 21, 2014

In 51f5b43: refs #5192 use menudropdown widget for language selector as well to simplify code and have same look&feel

@tsteur
Copy link
Member Author

tsteur commented May 21, 2014

In 69f91e2: refs #5192 align dropdown menu

@tsteur
Copy link
Member Author

tsteur commented May 21, 2014

In 2fca052: refs #5192 order user menu items + some UI tweaks and simplify

@tsteur
Copy link
Member Author

tsteur commented May 26, 2014

In 8edcf51: refs #5192 no longer needed to pass the menu instance in the event, only added it for easier refactoring

@tsteur
Copy link
Member Author

tsteur commented May 26, 2014

In af0e0c6: refs #5192 added some doc blocks and prevent the menu hooks from appearing in the documentation as they are deprecated

@tsteur
Copy link
Member Author

tsteur commented May 26, 2014

In e985743: Merge pull request #291 from piwik/5192_menu

refs #5192 Simplify / improve top menu

@tsteur
Copy link
Member Author

tsteur commented May 26, 2014

In efbe53d: refs #5192 fix typo

@tsteur
Copy link
Member Author

tsteur commented May 26, 2014

In f5b0ec5: refs #5192 another typo

@tsteur
Copy link
Member Author

tsteur commented May 26, 2014

In 45fa682: refs #5192 by adding this directive the language selector can be closed by pressing anywhere else or esc

@tsteur
Copy link
Member Author

tsteur commented May 26, 2014

In 29b0ae7: refs #5192 fixed some screenshot tests

@tsteur
Copy link
Member Author

tsteur commented May 28, 2014

In 3dd18db: refs #5192 updated docs

@tsteur
Copy link
Member Author

tsteur commented Jun 13, 2014

closing this ticket for now as it is working. Documentation is already updated but need to document the deprecation of the Menu events which is covered in #5327

If someone wants to suggest a better design of the menu create a new ticket please. I just reused the existing "style/design".

@tsteur tsteur added this to the 2.4.0 - Piwik 2.4.0 milestone Jul 8, 2014
@tsteur tsteur self-assigned this Jul 8, 2014
This was referenced Jun 30, 2014
Closed
Closed
tsteur added a commit that referenced this issue Jul 22, 2014
@tsteur
refs #5192 simplified admin menu since it is very confusing for devel…
f6d87ba 
…opers to find the correct translation key to use for menuName. Results in lots of dulicated code as well (same translation keys are mentioned everywhere). Also removed the $displayedForCurrentUsers in those methods since boolean parameters are bad practice and it did result in duplicated code as well as you had to call the same function or pass the same variable in each add() call. Moved the VisitorGenerator in a development section since it is not really diagnostic. There will be another development menu item with the next commit. Need to update ui tests
tsteur added a commit that referenced this issue Jul 22, 2014
@tsteur
refs #5192 some more menu api tweaks. MenuReporting is not 100% good …
3964ebc 
…since it is in core and should not know whether are actions, referrers and visitors item but it is very convenient for developers. Once we have DI we could add those methods there
tsteur added a commit that referenced this issue Jul 22, 2014
@tsteur
refs #5192 forgot the since annotation
02cc2ab
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsteur tsteur

Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Milestone
2.4.0
Development

No branches or pull requests
1 participant
@tsteur