Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply default filter_limit to all API calls #8458

Closed
tsteur opened this Issue Jul 29, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@tsteur
Copy link
Member

commented Jul 29, 2015

In 2d721cf#diff-206e6082c2ac821ef0396bf60abbfec7R221 we added the support of filter_limit for API calls that return an array. However, we could not apply the default filter limit to those API calls as it would break the API. We would have suddenly returned only 100 entities instead of all entities for all API methods that return an array.

For Piwik 3.0 we can break the API as it is easy to adjust for users and we get rid of this method: 2d721cf#diff-206e6082c2ac821ef0396bf60abbfec7R221 and this line: 2d721cf#diff-16262025799e2435d8bd28df29a147f1R33 which were needed to not break the API

@tsteur tsteur added this to the 3.0.0 milestone Jul 29, 2015

@tsteur

This comment has been minimized.

Copy link
Member Author

commented Apr 4, 2016

@mattab can you confirm making this change is ok for Piwik 3.0?

@mattab

This comment has been minimized.

Copy link
Member

commented Apr 4, 2016

@tsteur applying the filter_limit for API calls returning an array will make the API behaviour consistent across data types (arrays, datatables, ...) - this new consistency makes it worth to slightly break BC of some of the API endpoints, so 👍

@tsteur tsteur self-assigned this Apr 5, 2016

@tsteur tsteur modified the milestones: 3.0.0-b1, 3.0.0 Apr 5, 2016

tsteur added a commit to matomo-org/matomo-log-analytics that referenced this issue Apr 8, 2016

tsteur added a commit that referenced this issue Aug 30, 2016

Apply default filter_limit to all API calls (#10009)
* fix #8458 Apply default filter_limit to all API calls

* return all results where needed instead of default filter limit of 100

* make sure to apply offset

* fix unit tests

* fix import logs test as they post the filter value

tsteur added a commit that referenced this issue Aug 31, 2016

Apply default filter_limit to all API calls (#10009)
* fix #8458 Apply default filter_limit to all API calls

* return all results where needed instead of default filter limit of 100

* make sure to apply offset

* fix unit tests

* fix import logs test as they post the filter value

tsteur added a commit that referenced this issue Sep 1, 2016

Apply default filter_limit to all API calls (#10009)
* fix #8458 Apply default filter_limit to all API calls

* return all results where needed instead of default filter limit of 100

* make sure to apply offset

* fix unit tests

* fix import logs test as they post the filter value

tsteur added a commit that referenced this issue Sep 1, 2016

Apply default filter_limit to all API calls (#10009)
* fix #8458 Apply default filter_limit to all API calls

* return all results where needed instead of default filter limit of 100

* make sure to apply offset

* fix unit tests

* fix import logs test as they post the filter value

@tsteur tsteur closed this Sep 13, 2016

@mattab mattab added the Major label Oct 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.