-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chrome shows empty opt-out iframe #8634
Comments
Current Chrome you mean version 44? I just tried to reproduce but works fine for me. Quickly had a look at the code but couldn't find why it should be set multiple times, only had a quick view though. Are you using any custom plugins? What's your PHP version? |
Yes, Chrome 44.0 (Linux). But the Problem is the same under Chrome/MacOSX (dont know Chrome version there). PHP is 5.5.9-1ubuntu4.11 One Plugin is installed: CustomOptOut (v0.3.1) The Error in chrome console is:
My current workaround is: if ((string)$this->xFrameOptions != '') {
Common::sendHeader('X-Frame-Options: ' . (string)$this->xFrameOptions);
} |
Just noticed it was moved to 2.15.0. Maybe someone else from the team can try to reproduce it and if so, work on a fix |
@renegat4 I also can't reproduce. Which version of Piwik are you using? did you maybe customise the config.ini.php with some settings? |
Current Chrome doesn't show the opt-out because of conflicting Values for X-Frame-Options.
Source seems to be in core/View.php:
The header ist set two times, first with 'sameorigin' second empty.
So the last one will not prevail. Chrome sees them all and refuses to show the content.
The text was updated successfully, but these errors were encountered: