Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unload plugin instead of deactivating it when a plugin has a missing dependency #11682

Merged
merged 1 commit into from
May 12, 2017
Merged

Unload plugin instead of deactivating it when a plugin has a missing dependency #11682

merged 1 commit into from
May 12, 2017

Commits on May 9, 2017

  1. Unload plugin instead of deactivating it when a plugin has a missing … 

    …dependency

Deactivating a plugin in case of a missing dependency is a bit risky. If just once a dependency is missing it would be directly deactivated. For example during an update we may run into an issue where a plugin dependency might be missing just for a short time frame. There may be also other edge cases where this might be the case. It would be better to instead trigger a notification only. I would show this notification only to super users but we do not have anything loaded at this time.

Any other ideas?
    @tsteur
    tsteur committed May 9, 2017
    Configuration menu
    Copy the full SHA
    9f1a1ed View commit details
    Browse the repository at this point in the history