Added missing method rowCount to db classes #11698
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just ran into an issue where I used the
Db::rowCount
method. This works fine when being in tracker mode and code works as the Db tracker has this method. However, when writing tests for it, it may use the regular Db during the tests which means the test fails. Therefore I added the missing methods to make the tests work.Not sure if this is considered a bug, an enhancement, whether we should mention it in changelog or not.