Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure to always trigger a callback in JS trigger when specified #13855

Merged
merged 5 commits into from Dec 13, 2018

Conversation

Projects
None yet
2 participants
@tsteur
Copy link
Member

tsteur commented Dec 13, 2018

No description provided.

js/piwik.js Outdated
@@ -3561,6 +3568,10 @@ if (typeof window.Piwik !== 'object') {
return false;
}

if (success && typeof callback === 'function') {
callback({request: request, trackerUrl: configTrackerUrl, success: true});

This comment has been minimized.

Copy link
@diosmosis

diosmosis Dec 13, 2018

Member

Since this assumes success, would it help to add, eg, isSendBeacon: true? Just in case someone might want to tell. I'm not sure of a use case for that though.

This comment has been minimized.

Copy link
@tsteur

tsteur Dec 13, 2018

Author Member

doesn't hurt 👍 will add it

This comment has been minimized.

Copy link
@tsteur

tsteur Dec 13, 2018

Author Member

done

tsteur added some commits Dec 13, 2018

@diosmosis diosmosis merged commit 24b26c6 into 3.x-dev Dec 13, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@diosmosis diosmosis deleted the jscallback branch Dec 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.