Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "open source web analytics" tooltip in app logo when a custom logo is uploaded #14620

Merged
merged 1 commit into from Jul 3, 2019

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Jul 3, 2019

refs DEV-1702
This way it won't be shown when using eg white label etc.

…logo is uploaded

refs DEV-1702
This way it won't be shown when using eg white label etc.
@tsteur tsteur added the Needs Review PRs that need a code review label Jul 3, 2019
@tsteur tsteur added this to the 3.11.0 milestone Jul 3, 2019
Copy link
Member

@diosmosis diosmosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Though we could also replace this in whitelabel correct? I assume the text isn't that important to keep, but thought I'd mention this possibility.

@tsteur tsteur merged commit 0969b1d into 3.x-dev Jul 3, 2019
@tsteur tsteur deleted the dev1702 branch July 3, 2019 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants