-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove unnecessary number format in visit summary #15218
Conversation
There seems to be some regression: https://builds-artifacts.matomo.org/matomo-org/matomo/3.x-dev/37206/UnprocessedSegmentTest_unprocessed_segment.png |
I guess that is kind of expected. The generation time is a computed metric. But when no generation time has been tracked, the metric is not computed and thus the value is actually matomo/core/Metrics/Formatter.php Lines 201 to 203 in 3f26e78
But as the sparklines are using a number filter for the values it gets converted to 0 in matomo/plugins/CoreVisualizations/templates/macros.twig Lines 37 to 41 in f1d6cc7
|
OK might need to update the tests then 👍 |
8b64585
to
b686181
Compare
tests are updated now |
* remove unnecessary number format in visit summary * updates UI tests
* remove unnecessary number format in visit summary * updates UI tests
number formatting is meanwhile done somewhere else. For some local formats this second formatting breaks the numbers...
fixes #15200