Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable features that are inaccurate if visit data is not profilable #16773

Open
wants to merge 120 commits into
base: 4.x-dev
Choose a base branch
from

Commits on Oct 29, 2020

  1. Configuration menu
    Copy the full SHA
    cb6daac View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2020

  1. Configuration menu
    Copy the full SHA
    aa1d459 View commit details
    Browse the repository at this point in the history
  2. implement requiresProfilableVisitors() in some reports and use to dis…

    …able a couple features
    diosmosis committed Oct 30, 2020
    Configuration menu
    Copy the full SHA
    193c0e8 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2020

  1. Configuration menu
    Copy the full SHA
    6bef1e6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    203d9d7 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2020

  1. Configuration menu
    Copy the full SHA
    60d6af3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d7345ed View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2020

  1. Configuration menu
    Copy the full SHA
    bd15cda View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    939f6e3 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2020

  1. default value

    diosmosis committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    22300fb View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2020

  1. Configuration menu
    Copy the full SHA
    b3cd71c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8977dd4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ec7d33e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6df46dc View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2020

  1. change Report::requiresProfilableVisitors() method name and disable r…

    …eports based on dimensions that require profilable data too
    diosmosis committed Nov 22, 2020
    Configuration menu
    Copy the full SHA
    1a1b3b3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    be876af View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2020

  1. Configuration menu
    Copy the full SHA
    3f37ae3 View commit details
    Browse the repository at this point in the history
  2. start on automated test

    diosmosis committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    3e603c8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0f54f90 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2020

  1. allow nb_profilable to be saved even if it is zero so we can differen…

    …tiate between archives w/o it and archives where it is 0
    diosmosis committed Nov 27, 2020
    Configuration menu
    Copy the full SHA
    9cc29a3 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2020

  1. test more APIs

    diosmosis committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    1833576 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2020

  1. Configuration menu
    Copy the full SHA
    a077880 View commit details
    Browse the repository at this point in the history
  2. finish UI test

    diosmosis committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    909f772 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2020

  1. some docs

    diosmosis committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    4d9d066 View commit details
    Browse the repository at this point in the history
  2. clear some todo

    diosmosis committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    edf1b17 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    130419a View commit details
    Browse the repository at this point in the history
  4. remove TODO

    diosmosis committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    6843c1f View commit details
    Browse the repository at this point in the history
  5. more TODO docs

    diosmosis committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    afa6503 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    ca91a39 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2020

  1. Configuration menu
    Copy the full SHA
    de80d92 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2020

  1. Configuration menu
    Copy the full SHA
    f7dda63 View commit details
    Browse the repository at this point in the history
  2. update expected test files

    diosmosis committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    f044c4b View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2020

  1. Configuration menu
    Copy the full SHA
    74d09ea View commit details
    Browse the repository at this point in the history
  2. update more expected files

    diosmosis committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    f9d3993 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2020

  1. fix some tests

    diosmosis committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    dd5a6bf View commit details
    Browse the repository at this point in the history
  2. fix test

    diosmosis committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    a9c4d22 View commit details
    Browse the repository at this point in the history
  3. fix more tests

    diosmosis committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    d93b345 View commit details
    Browse the repository at this point in the history
  4. fix more tests

    diosmosis committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    728c3d5 View commit details
    Browse the repository at this point in the history
  5. fix more tests

    diosmosis committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    74f5db1 View commit details
    Browse the repository at this point in the history
  6. more test fixing

    diosmosis committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    2c27a98 View commit details
    Browse the repository at this point in the history
  7. update expected screenshots

    diosmosis committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    21de72d View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2020

  1. condition tweak

    diosmosis committed Dec 20, 2020
    Configuration menu
    Copy the full SHA
    02ca3d4 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2020

  1. fill out / remove some TODO

    diosmosis committed Dec 21, 2020
    Configuration menu
    Copy the full SHA
    e45f361 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2021

  1. Configuration menu
    Copy the full SHA
    7949371 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7836482 View commit details
    Browse the repository at this point in the history
  3. put transient cache in Request method instead of VisitsSummary.isProf…

    …ilable since no one else should call that API method directly
    diosmosis committed Jan 17, 2021
    Configuration menu
    Copy the full SHA
    c3f21ce View commit details
    Browse the repository at this point in the history
  4. fix segment use

    diosmosis committed Jan 17, 2021
    Configuration menu
    Copy the full SHA
    6555968 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d3579bd View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2021

  1. Configuration menu
    Copy the full SHA
    2e944ab View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2021

  1. Configuration menu
    Copy the full SHA
    ecd256e View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2021

  1. Configuration menu
    Copy the full SHA
    6d83b61 View commit details
    Browse the repository at this point in the history
  2. applying some pr feedback

    diosmosis committed Aug 28, 2021
    Configuration menu
    Copy the full SHA
    3f48e0c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    cb630cb View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2021

  1. apply more review feedback

    diosmosis committed Aug 29, 2021
    Configuration menu
    Copy the full SHA
    2721ef9 View commit details
    Browse the repository at this point in the history
  2. add test for segment method

    diosmosis committed Aug 29, 2021
    Configuration menu
    Copy the full SHA
    2d4c7ee View commit details
    Browse the repository at this point in the history
  3. fix a test error

    diosmosis committed Aug 29, 2021
    Configuration menu
    Copy the full SHA
    ce6534f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2c84a17 View commit details
    Browse the repository at this point in the history
  5. update expected tests

    diosmosis committed Aug 29, 2021
    Configuration menu
    Copy the full SHA
    3a84121 View commit details
    Browse the repository at this point in the history
  6. update submodules

    diosmosis committed Aug 29, 2021
    Configuration menu
    Copy the full SHA
    36bbccb View commit details
    Browse the repository at this point in the history
  7. update expected screenshots

    diosmosis committed Aug 29, 2021
    Configuration menu
    Copy the full SHA
    c0d2262 View commit details
    Browse the repository at this point in the history
  8. update expected files again

    diosmosis committed Aug 29, 2021
    Configuration menu
    Copy the full SHA
    8fbcd7e View commit details
    Browse the repository at this point in the history
  9. update submodule

    diosmosis committed Aug 29, 2021
    Configuration menu
    Copy the full SHA
    b8ff9d4 View commit details
    Browse the repository at this point in the history
  10. fix more tests

    diosmosis committed Aug 29, 2021
    Configuration menu
    Copy the full SHA
    78093a6 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2021

  1. Configuration menu
    Copy the full SHA
    79355ac View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    08c1608 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ba5d50f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    455685c View commit details
    Browse the repository at this point in the history

Commits on May 9, 2022

  1. add nb_profilable core metricc

    diosmosis authored and sgiehl committed May 9, 2022
    Configuration menu
    Copy the full SHA
    1713914 View commit details
    Browse the repository at this point in the history
  2. implement requiresProfilableVisitors() in some reports and use to dis…

    …able a couple features
    diosmosis authored and sgiehl committed May 9, 2022
    Configuration menu
    Copy the full SHA
    a686a65 View commit details
    Browse the repository at this point in the history
  3. disable returning/new visitors on visitor log based on whether visito…

    …r is profilable
    diosmosis authored and sgiehl committed May 9, 2022
    Configuration menu
    Copy the full SHA
    e3942cc View commit details
    Browse the repository at this point in the history
  4. take userid into account as well

    diosmosis authored and sgiehl committed May 9, 2022
    Configuration menu
    Copy the full SHA
    d3875a9 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d0528ff View commit details
    Browse the repository at this point in the history
  6. default value

    diosmosis authored and sgiehl committed May 9, 2022
    Configuration menu
    Copy the full SHA
    7b8b8e8 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    5247254 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    48532ca View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    9213ad3 View commit details
    Browse the repository at this point in the history
  10. change Report::requiresProfilableVisitors() method name and disable r…

    …eports based on dimensions that require profilable data too
    diosmosis authored and sgiehl committed May 9, 2022
    Configuration menu
    Copy the full SHA
    7420ec7 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    6920256 View commit details
    Browse the repository at this point in the history
  12. start on automated test

    diosmosis authored and sgiehl committed May 9, 2022
    Configuration menu
    Copy the full SHA
    cc5f582 View commit details
    Browse the repository at this point in the history
  13. add another visit to fixture

    diosmosis authored and sgiehl committed May 9, 2022
    Configuration menu
    Copy the full SHA
    7418a98 View commit details
    Browse the repository at this point in the history
  14. allow nb_profilable to be saved even if it is zero so we can differen…

    …tiate between archives w/o it and archives where it is 0
    diosmosis authored and sgiehl committed May 9, 2022
    Configuration menu
    Copy the full SHA
    122fb74 View commit details
    Browse the repository at this point in the history
  15. test more APIs

    diosmosis authored and sgiehl committed May 9, 2022
    Configuration menu
    Copy the full SHA
    ab82c21 View commit details
    Browse the repository at this point in the history
  16. finish UI test

    diosmosis authored and sgiehl committed May 9, 2022
    Configuration menu
    Copy the full SHA
    dc14820 View commit details
    Browse the repository at this point in the history
  17. some docs

    diosmosis authored and sgiehl committed May 9, 2022
    Configuration menu
    Copy the full SHA
    26eb2a2 View commit details
    Browse the repository at this point in the history
  18. clear some todo

    diosmosis authored and sgiehl committed May 9, 2022
    Configuration menu
    Copy the full SHA
    8757e25 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    4289b9d View commit details
    Browse the repository at this point in the history
  20. remove TODO

    diosmosis authored and sgiehl committed May 9, 2022
    Configuration menu
    Copy the full SHA
    4a4e571 View commit details
    Browse the repository at this point in the history
  21. more TODO docs

    diosmosis authored and sgiehl committed May 9, 2022
    Configuration menu
    Copy the full SHA
    69711ae View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    b6c7996 View commit details
    Browse the repository at this point in the history
  23. update expected test files

    diosmosis authored and sgiehl committed May 9, 2022
    Configuration menu
    Copy the full SHA
    c140fd7 View commit details
    Browse the repository at this point in the history
  24. update more expected files

    diosmosis authored and sgiehl committed May 9, 2022
    Configuration menu
    Copy the full SHA
    4179989 View commit details
    Browse the repository at this point in the history
  25. fix some tests

    diosmosis authored and sgiehl committed May 9, 2022
    Configuration menu
    Copy the full SHA
    61a5f9f View commit details
    Browse the repository at this point in the history
  26. fix test

    diosmosis authored and sgiehl committed May 9, 2022
    Configuration menu
    Copy the full SHA
    84d3d8e View commit details
    Browse the repository at this point in the history
  27. fix more tests

    diosmosis authored and sgiehl committed May 9, 2022
    Configuration menu
    Copy the full SHA
    994da69 View commit details
    Browse the repository at this point in the history
  28. fix more tests

    diosmosis authored and sgiehl committed May 9, 2022
    Configuration menu
    Copy the full SHA
    4295506 View commit details
    Browse the repository at this point in the history
  29. fix more tests

    diosmosis authored and sgiehl committed May 9, 2022
    Configuration menu
    Copy the full SHA
    9e13c69 View commit details
    Browse the repository at this point in the history
  30. more test fixing

    diosmosis authored and sgiehl committed May 9, 2022
    Configuration menu
    Copy the full SHA
    f1f6ddd View commit details
    Browse the repository at this point in the history
  31. update expected screenshots

    diosmosis authored and sgiehl committed May 9, 2022
    Configuration menu
    Copy the full SHA
    5a517c6 View commit details
    Browse the repository at this point in the history
  32. condition tweak

    diosmosis authored and sgiehl committed May 9, 2022
    Configuration menu
    Copy the full SHA
    24efff8 View commit details
    Browse the repository at this point in the history
  33. fill out / remove some TODO

    diosmosis authored and sgiehl committed May 9, 2022
    Configuration menu
    Copy the full SHA
    675b382 View commit details
    Browse the repository at this point in the history
  34. Configuration menu
    Copy the full SHA
    986624d View commit details
    Browse the repository at this point in the history
  35. put transient cache in Request method instead of VisitsSummary.isProf…

    …ilable since no one else should call that API method directly
    diosmosis authored and sgiehl committed May 9, 2022
    Configuration menu
    Copy the full SHA
    6659c48 View commit details
    Browse the repository at this point in the history
  36. fix segment use

    diosmosis authored and sgiehl committed May 9, 2022
    Configuration menu
    Copy the full SHA
    49587b1 View commit details
    Browse the repository at this point in the history
  37. Configuration menu
    Copy the full SHA
    3996bf6 View commit details
    Browse the repository at this point in the history
  38. apply some more review feedback

    diosmosis authored and sgiehl committed May 9, 2022
    Configuration menu
    Copy the full SHA
    3276bf1 View commit details
    Browse the repository at this point in the history
  39. applying some pr feedback

    diosmosis authored and sgiehl committed May 9, 2022
    Configuration menu
    Copy the full SHA
    7fe1b1d View commit details
    Browse the repository at this point in the history
  40. apply some more review feedback

    diosmosis authored and sgiehl committed May 9, 2022
    Configuration menu
    Copy the full SHA
    173deaa View commit details
    Browse the repository at this point in the history
  41. apply more review feedback

    diosmosis authored and sgiehl committed May 9, 2022
    Configuration menu
    Copy the full SHA
    d345160 View commit details
    Browse the repository at this point in the history
  42. add test for segment method

    diosmosis authored and sgiehl committed May 9, 2022
    Configuration menu
    Copy the full SHA
    33f8625 View commit details
    Browse the repository at this point in the history
  43. fix a test error

    diosmosis authored and sgiehl committed May 9, 2022
    Configuration menu
    Copy the full SHA
    524adb6 View commit details
    Browse the repository at this point in the history
  44. modify UI tests for new code changes

    diosmosis authored and sgiehl committed May 9, 2022
    Configuration menu
    Copy the full SHA
    277018c View commit details
    Browse the repository at this point in the history
  45. update expected tests

    diosmosis authored and sgiehl committed May 9, 2022
    Configuration menu
    Copy the full SHA
    b372c39 View commit details
    Browse the repository at this point in the history
  46. update expected screenshots

    diosmosis authored and sgiehl committed May 9, 2022
    Configuration menu
    Copy the full SHA
    0694bb4 View commit details
    Browse the repository at this point in the history
  47. update expected files again

    diosmosis authored and sgiehl committed May 9, 2022
    Configuration menu
    Copy the full SHA
    07fe8fb View commit details
    Browse the repository at this point in the history
  48. fix more tests

    diosmosis authored and sgiehl committed May 9, 2022
    Configuration menu
    Copy the full SHA
    792d7aa View commit details
    Browse the repository at this point in the history
  49. Configuration menu
    Copy the full SHA
    440bdb0 View commit details
    Browse the repository at this point in the history
  50. Configuration menu
    Copy the full SHA
    24e23c2 View commit details
    Browse the repository at this point in the history
  51. Configuration menu
    Copy the full SHA
    6636838 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2022

  1. Configuration menu
    Copy the full SHA
    f439985 View commit details
    Browse the repository at this point in the history
  2. Merge branch '16363-profilable-disable-features' of github.com:matomo…

    …-org/matomo into 16363-profilable-disable-features
    diosmosis committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    e4367a6 View commit details
    Browse the repository at this point in the history