Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor 'user info changed' emails away from the generic Mail class #18593

Merged
merged 1 commit into from Jan 10, 2022
Merged

Refactor 'user info changed' emails away from the generic Mail class #18593

merged 1 commit into from Jan 10, 2022

Conversation

samjf
Copy link
Contributor

@samjf samjf commented Jan 10, 2022

Description:

Issue: DEV-2501

This refactors the emails produced by the UserManager plugin into their own sub-class of Mail. Before this it simply composed emails from the generic class.

This will allow subscribers of the Mail.shouldSend hook to better differentiate between what emails are being sent.

Review

@samjf samjf added the Needs Review PRs that need a code review label Jan 10, 2022
sgiehl
sgiehl approved these changes Jan 10, 2022
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work as expected

@sgiehl sgiehl added this to the 4.7.0 milestone Jan 10, 2022
@sgiehl sgiehl added c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. and removed Needs Review PRs that need a code review labels Jan 10, 2022
@sgiehl sgiehl merged commit d17b842 into 4.x-dev Jan 10, 2022
@sgiehl sgiehl deleted the D2501-add-user-info-changed-email branch January 10, 2022 15:37
@justinvelluppillai justinvelluppillai added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
c: Platform For Matomo platform changes that aren't impacting any of our APIs but improve the core itself. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.7.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@samjf @sgiehl @justinvelluppillai